Skip to content

Revision-detection code is fragile #43

Open

Description

@lurch

I think the test in quick2wire/board_revision.py needs to be made more robust.
I've just seen from http://elinux.org/RPi_HardwareHistory that the board revisions already go up to 000f.
With the current code in board_revision.py, as soon as the board revision hits 0012, it'll get mis-identified as a Revsion1 board (and hence use the wrong GPIO pin mapping).

The references from my previous bug report #14 still apply ;-)

Activity

  1. pckeller29 commented on Nov 27, 2014

    @pckeller29

    You are totally right.
    I'm using quick2wire on raspberry A+ (A plus) model. The revision number is 0012 and then the default bus is 0 which is wrong. I was able to run my python script by forcing default bus to 1 otherwise I always get an Error 5, write error when using I2C.

  2. lurch commented on Nov 27, 2014

    @lurch
    Author

    The last commit to this project was nearly 18 months ago, so a fix for this seems very unlikely :-/

  3. pckeller29 commented on Nov 27, 2014

    @pckeller29

    You're definitely right and I don't expect a corrective patch. I was able to solve this small issue myself.
    Thanx for replying.

    ----- Mail original -----
    De: "Andrew Scheller" notifications@github.com
    À: "quick2wire/quick2wire-python-api" quick2wire-python-api@noreply.github.com
    Cc: "pckeller29" spore@free.fr
    Envoyé: Jeudi 27 Novembre 2014 12:35:36
    Objet: Re: [quick2wire-python-api] Revision-detection code is fragile (#43)

    The last commit to this project was nearly 18 months ago, so a fix for this seems very unlikely :-/

    —
    Reply to this email directly or view it on GitHub .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions