Conversation
Owner
Author
|
Closed because this PR was opened against the fork by mistake. The upstream PR is pingdotgg#5960. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
Grok provider snapshots did not include filesystem skills, leaving the existing
$picker empty when Grok was selected.discoverSkillsFromRoots, with best-effort frontmatter parsing and later-root collision precedence..agents/skillsand.grok/skills.Why
Grok can use skills from these standard filesystem locations, but T3 only exposed Claude's discovered skills to clients. Sharing the scan keeps the parsing and override behavior consistent while leaving provider-specific root resolution at the adapter boundary.
UI Changes
No client UI code changed. The existing
$picker now receives Grok skills through the provider snapshot contract.Verification
vp test run ...— 31 focused provider tests passedvp run typecheck— passed across the workspace (pre-existing Effect suggestions only)Checklist
Implemented with GPT-5.6 Codex in the T3 Code harness.