ui.py: Reuse existing windows on resize

[Consolatis]

Reuse existing curses windows on resize instead of recreating them

Edit:
To clarify the reasoning for this change: I added this because my local WIP branch for statusbar components creates an instance of StatusBar() for each bar (currently only top and bottom) which gets a curses window via constructor so the window should always be available.

Things to do:

• investigate editor move error
• squash
• rebase

[Consolatis]

I did not check if self.warned_old_curses has other implications outside of ui.py or can be removed completely after this change. A quick grep -R inside the repo seems to suggest it can be removed completely. If that is indeed the case I'll remove it from __init__ as well.

Edit:
Force pushed a new version which removed it.

[richrd]

That's ok. It's not used anywhere else like you said.

[Consolatis]

With this applied I sometimes get log outputs from the editor win like this:

2018-01-23 13:07:19,678 - suplemon.viewer - WARNING - Moving window failed!
Traceback (most recent call last):
  File "/path/to/suplemon/suplemon/viewer.py", line 284, in move_win
    self.window.mvwin(yx[0], yx[1])
_curses.error: mvwin() returned ERR

It doesn't seem to affect anything but still strange. Will need to investigate.

[richrd]

I seem to be getting some errors when resizing the terminal. It works fine and everything looks like it should, but curses complains a little bit:

2018-01-21 17:33:15,393 - suplemon.viewer - WARNING - Moving window failed!
Traceback (most recent call last):
  File "/home/wavi/code/python/suplemon-contrib/consolatis-suplemon/suplemon/viewer.py", line 284, in move_win
    self.window.mvwin(yx[0], yx[1])
_curses.error: mvwin() returned ERR

This seems to go away if the two lines above are swapped, so that resize is run first and move_win after that. I'm guessing it might be complaining because the window is too big and would be placed on top of the legend or status bar after the move. I'm not sure though.

I think it'd be fine to just swap the lines and go forward with this 👍

[richrd]

Oops, forgot to submit my comment earlier. See above. The mvwin was wrapped with that try/except a long time ago because I noticed that it might fail randomly sometimes. It's no big deal but the above seems to help.

[Consolatis]

Switched those two around and indeed: no more errors showing up.
If there is nothing else to do I'll squash those two commits into one.

[richrd]

Yeah, that's all :) Thanks!

[Consolatis]

squashed the commits :)

[richrd]

Merged :)