Repository navigation
unblocked scrolling - #56
Merged
Merged
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The global overflow-y: auto !important risks breaking modal background scroll-lock behavior (e.g., Radix Dialog) and the PR description doesn’t match what the diff actually changes.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR aims to restore page scrolling by adjusting global html, body overflow behavior in app/globals.css.
Changes:
- Adds
htmlto the global selector and setsmin-height: 100%. - Forces horizontal overflow hidden and vertical scrolling enabled via
overflow-y: auto(currently with!important).
File summaries
| File | Description |
|---|---|
| app/globals.css | Updates global html, body styling to enforce vertical scrolling and prevent horizontal overflow. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+119
to
+124
| html, | ||
| body { | ||
| @apply bg-background text-foreground; | ||
| min-height: 100%; | ||
| overflow-x: hidden; | ||
| overflow-y: auto !important; |
Comment on lines
+119
to
125
| html, | ||
| body { | ||
| @apply bg-background text-foreground; | ||
| min-height: 100%; | ||
| overflow-x: hidden; | ||
| overflow-y: auto !important; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scrolling was blocked because html and body had overflow: hidden; we fixed it by globally enforcing overflow-y:auto !important in globals.css.