You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I wasn't too happy about the naming, but that has been what we have settled on.
Now that we have been moving bindings to their own repos, I've been thinking of moving the old WebView bindings to their own repo, so that we can remove them from the RN bindings without issue and yet allow people to remain on older versions of RN.
With such a move, I would prefer that the components be named WebView instead (and likewise for NetInfo, Slider etc).
Kinda related: Due to a quite extensive upgrade from BS v7 + reason-react-native 0.61 and reason-react, I had to vendor most of the dependent reason-react-native libraries to even be able to upgrade properly.
Turned out, the ReactNativeWebview module is a 400 lines module, which could easily distributed as a single file.
Activity
sgny commentedon Sep 21, 2019
I wasn't too happy about the naming, but that has been what we have settled on.
Now that we have been moving bindings to their own repos, I've been thinking of moving the old
WebViewbindings to their own repo, so that we can remove them from the RN bindings without issue and yet allow people to remain on older versions of RN.With such a move, I would prefer that the components be named
WebViewinstead (and likewise forNetInfo,Slideretc).ryyppy commentedon May 15, 2021
Kinda related: Due to a quite extensive upgrade from BS v7 + reason-react-native 0.61 and reason-react, I had to vendor most of the dependent reason-react-native libraries to even be able to upgrade properly.
Turned out, the ReactNativeWebview module is a 400 lines module, which could easily distributed as a single file.
Wouldn't this be a better option?