Repository navigation
Fix errors from test wild - #294
Merged
Merged
Conversation
- Source-typed coercions such as `(value: sourceType :> targetType)`. - Method chains beginning with `.` on the next line. - Post-default parameter annotations such as `~chain=#1: chainId`.
The issue was a block comment between variant constructors: ```rescript | ThrowsMatchSnapshot(unit => _): assertion /* JS */ | Defined(...) ``` The significant newline before the comment prematurely ended `variant_type`. The variant separator now accepts these newlines and uses a local GLR conflict to distinguish declaration termination from additional constructors
The scanner treated any identifier beginning with `with` as the module-constraint keyword. Consequently, the newline before `withExhaustiveCheck` was suppressed and two mutations were merged. scanner.c now requires whitespace after `with`, confirming it is a standalone keyword. Added regression coverage in expressions.txt
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8433765a3d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
(value: sourceType :> targetType)~chain=#1: chainIdwith, such aswithExhaustiveCheck, from being mistaken for thewithkeywordClose #293