Skip to content

Fix comment removed when function signature has type keyword - #6997

Merged
cknitt merged 2 commits into
rescript-lang:masterfrom
shulhi:fix-comment-removed-in-function-signature
Sep 1, 2024
Merged

cknitt merged 2 commits into
rescript-lang:masterfrom
shulhi:fix-comment-removed-in-function-signature

Conversation

@shulhi

@shulhi shulhi commented Sep 1, 2024

Copy link
Copy Markdown
Member

Fix #6890

@shulhi
shulhi marked this pull request as ready for review September 1, 2024 03:36
) => /* c7 */ ()

let multiply = (type /* c-2 */ t /* c-1 */, m1 /* c1 */, /* c2 */ m2 /* c3 */) => ()
let multiply = (type /* c-2 */ t /* c-1 */, /* c0 */ m1 /* c1 */, /* c2 */ m2 /* c3 */) => ()

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original code actually had the comment, but the expected outcome didn't.

@shulhi
shulhi requested a review from cknitt September 1, 2024 03:39

@cknitt cknitt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@cknitt
cknitt merged commit f5ca410 into rescript-lang:master Sep 1, 2024
cknitt pushed a commit to cknitt/rescript that referenced this pull request Sep 8, 2024
…t-lang#6997)

* Fix comment removed when function signature has type keyword

* Update CHANGELOG
cknitt pushed a commit that referenced this pull request Sep 10, 2024
* Fix comment removed when function signature has type keyword

* Update CHANGELOG
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Comment formatted away in uncurried mode

2 participants