Extend quoting functionality to include polyvariant keywords

[WhyThat]

Hey,
Following up #870, we have now extended the functionality to also wrap polyvariant keywords with quotes.

[zth]

Great stuff! Can you add a changelog?

[WhyThat]

@zth Done :)
Just thinking about it, we could use fileNameHasUnallowedChars to detect if we have to wrap exotic polyvariant, wyt ?

[zth]

@zth Done :) Just thinking about it, we could use fileNameHasUnallowedChars to detect if we have to wrap exotic polyvariant, wyt ?

I don't think that's equivalent to what we do, right? Doesn't that check that the string is capitalized etc?

[WhyThat]

I don't think that's equivalent to what we do, right? Doesn't that check that the string is capitalized etc?

Seems like it match the same things after testing these cases :

let printMaybeExoticIdent txt =
  (* fileNameHasUnallowedChars "not good" (* => true *); *)
  (* fileNameHasUnallowedChars "not-good" (* => true *); *)
  (* fileNameHasUnallowedChars "good"(* => false *); *)
  (* fileNameHasUnallowedChars "Good"(* => false *); *)
  (* fileNameHasUnallowedChars "123"(* => false *); *)
  match (Res_token.isKeywordTxt txt, fileNameHasUnallowedChars txt) with
  | true, _ | _, true -> "\"" ^ txt ^ "\""
  | _ -> txt

test are unchanged with this, but nevermind