Repository navigation
Issue in left side edge nodes #43
Description
Hi @alisaono
All the node on the left edge their labels are cut off and also the tooltip is not working. Is there a way to add padding? Or any temporary solution?
{{ message }}
Hi @alisaono
All the node on the left edge their labels are cut off and also the tooltip is not working. Is there a way to add padding? Or any temporary solution?
Activity
alisaono commentedon Feb 9, 2018
Is the tooltip not showing at all? (It seems to be working on the website example, which should be using the latest versions) Is it giving you any errors/warning related to the network/tooltip?
Also maybe we should add a new prop to specify paddings (or margins, whatever you wanna call it)? @sanjaypojo @AlmahaAlmalki
AlmahaAlmalki commentedon Feb 9, 2018
alisaono commentedon Feb 9, 2018
Ah okay, so adding a prop for paddings should fix the problem?
AlmahaAlmalki commentedon Feb 9, 2018
sanjaypojo commentedon Feb 9, 2018
Maybe we don't even need a new prop for padding. Can we just have the bounding box for the nodes to be a couple of pixels inside the width / height? Do you think that'll do the trick @alisaono?
alisaono commentedon Feb 9, 2018
@sanjaypojo I guess my only concern with that was we don't know how long the labels can be. E.g. if we have constant paddings and someone had a long label that always gets cut off, there'd be no way to quickly fix that. So maybe it's more user friendly if we have a padding prop with some default value? What do you think?
alisaono commentedon Feb 9, 2018
^Well this is sort of similar to the x labels offset issue we had with the bar chart. If we are to have constant paddings for now, we should revisit later to calculate the padding in a smarter way...!
sanjaypojo commentedon Feb 9, 2018
Oh wait, I think I just understood the problem. Correct me if I'm wrong - the labels are getting cut off whenever they are outside the bounds of the chart? And independently, the tooltip isn't working?
alisaono commentedon Feb 9, 2018
Yea the labels are outside the bounds of chart. Tooltip issue might be related if tooltips also don't display when it's outside the bounds of chart
sanjaypojo commentedon Feb 9, 2018
Cool, makes sense! For the labels, let's solve it a different way - let's change the label position to start / end from middle, in case the node's final position is close to the edge of the chart. I think that shouldn't be too complicated and worth a shot! For the tooltip, I'm hoping a small amount of padding might solve it?
alisaono commentedon Feb 9, 2018
Well actually tooltip issue may be independent from the bound issue.
Tooltip shows up fine although the node is at the very edge. You can see the label cut off
@sanjaypojo
sanjaypojo commentedon Feb 9, 2018
Ah okay perfect. In that case, let's just solve the label problem for this issue. For the tooltip, we need to figure out the exact CSS / external conditions that seems to cause the offset and then mention it in our docs.
AlmahaAlmalki commentedon Feb 9, 2018
alisaono commentedon Feb 11, 2018
I wasn't able to reproduce this :/ Tooltip shows up for me even when it's on the left side edge. We can debug during the next in-person meeting, if you're still having this issue? @AlmahaAlmalki