chore(ci): remove unused Python names reported by CodeQL - #911
Conversation
Remove dead assignments and unused imports flagged by CodeQL, and move the CodeQL workflow to a config file that ignores the napi-rs generated index.js loaders, which are reproduced by the crate build and never hand-edited. Signed-off-by: Jeremi Joslin <jeremi@acn.fr>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
The release gate inventory greps codeql.yml for the security-and-quality suite, so the config file only carries the generated-path exclusion. Signed-off-by: Jeremi Joslin <jeremi@acn.fr>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fd6233a2f8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…leanup Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
…leanup Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
jeremi
changed the title
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 15bc776e0f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
1 participant
Remove three unused Python names reported by CodeQL:
tempfilein CI classifier tests,osin Relay adopter tests, and a deadrepositoryassignment in release manifest fixtures. Test behavior is unchanged.CodeQL retains its full source coverage and the existing
security-and-qualitysuite. The two generated-loader quality findings (#198 and #141) already have scoped alert dismissals; no path exclusion is needed.Verification:
Review triage: the query-suite inventory finding was fixed by retaining the suite in the workflow; the overly broad exclusion and missing config routing findings are resolved by removing the added configuration entirely. The Relay adopter journey was not rerun locally because its only change removes an unused import.
Final review triage: the missing-DCO report is inaccurate. All five PR commits, including
15bc776e0, containSigned-off-by:trailers and the DCO check passed. The area-splitting suggestion was evaluated: these three one-line test cleanups form one CodeQL maintenance change with no product behavior or ownership changes; the requested PR remains together, with each affected test surface checked proportionately.