Skip to content

#190 Add Java 25 Support - #218

Merged
jimbethancourt merged 8 commits into
mainfrom
#190-add-java25-support
Sep 23, 2026
Merged

jimbethancourt merged 8 commits into
mainfrom
#190-add-java25-support

Conversation

@jimbethancourt

@jimbethancourt jimbethancourt commented Sep 22, 2026 •

Copy link
Copy Markdown
Collaborator

Adding Java 25 support.

Summary by CodeRabbit

  • New Features

    • Added Java 25 code analysis support on Java 25 and newer runtimes.
    • Java 25 parsing is selected automatically; older runtimes continue using compatible parsers.
    • CLI and packaged tools retain Java 25 analysis support.
  • Bug Fixes

    • Improved analysis of Java 25 language features, with fallback to the standard parser if Java 25 parser initialization fails.
    • Improved reliability when reading Git history involving deleted files.
  • Documentation

    • Updated prerequisites and usage guidance for Java 17 and Java 25 environments.
    • Clarified that Java 25 parser activation requires no configuration.

Adding Java 25 support.
@coderabbitai

coderabbitai Bot commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: db9fa60f-6bfe-4af2-b07e-0928ffb570ce

📥 Commits

Reviewing files that changed from the base of the PR and between 978bfe6 and 15c6bc9.

📒 Files selected for processing (5)
  • codebase-graph-builder/src/main/java/org/hjug/graphbuilder/graphbuilder/Java25ParserFactory.java
  • codebase-graph-builder/src/main/java/org/hjug/graphbuilder/graphbuilder/JavaSourceFileGraphBuilder.java
  • codebase-graph-builder/src/main/java25/org/hjug/graphbuilder/graphbuilder/Java25ParserFactory.java
  • codebase-graph-builder/src/test/resources/java25SrcDirectory/com/example/java25/FlexibleConstructorBody.java
  • report/src/main/java/org/hjug/refactorfirst/report/SimpleHtmlReport.java
🚧 Files skipped from review as they are similar to previous changes (5)
  • codebase-graph-builder/src/test/resources/java25SrcDirectory/com/example/java25/FlexibleConstructorBody.java
  • codebase-graph-builder/src/main/java25/org/hjug/graphbuilder/graphbuilder/Java25ParserFactory.java
  • report/src/main/java/org/hjug/refactorfirst/report/SimpleHtmlReport.java
  • codebase-graph-builder/src/main/java/org/hjug/graphbuilder/graphbuilder/JavaSourceFileGraphBuilder.java
  • codebase-graph-builder/src/main/java/org/hjug/graphbuilder/graphbuilder/Java25ParserFactory.java

Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.


📝 Walkthrough

Walkthrough

The change adds Java 25 parser support through a JEP 238 multi-release jar. It updates parser selection, packaging, CI, release checks, callers, tests, documentation, and Git fixture cleanup.

Changes

Java 25 analysis

Layer / File(s) Summary
Multi-release parser selection and validation
codebase-graph-builder/src/main/java/..., codebase-graph-builder/src/main/java25/..., codebase-graph-builder/src/test/..., codebase-graph-builder/src/test/resources/...
The base factory returns an empty Optional. The Java 25 variant constructs Java25Parser and returns an empty Optional if construction fails. JavaSourceFileGraphBuilder uses the factory before the standard parser. Tests cover selection, API parity, jar shadowing, and Java 25 source analysis.
Multi-release packaging and build validation
.github/workflows/*, codebase-graph-builder/pom.xml, cli/pom.xml, pom.xml, refactor-first-maven-plugin/pom.xml
The build compiles Java 25 sources into META-INF/versions/25 and sets Multi-Release: true. It adds rewrite-java-25, updates build tooling, runs Java 17 and Java 25 jobs, and checks release artifacts.
Runtime-driven callers and tests
cost-benefit-calculator/..., report/...
CycleRanker passes GraphBuilderConfig and validates the repository path. Tests cover graph generation and report execution without parser-forcing arguments.
Java 25 documentation and implementation records
AGENTS.md, CLAUDE.md, README.md, plans/*
Documentation and plans describe parser activation, runtime requirements, packaging constraints, tests, and release checks.

Git fixture cleanup reliability

Layer / File(s) Summary
Git test repository and cleanup
change-proneness-ranker/src/test/java/org/hjug/git/GitLogReaderTest.java
The Git test reopens the repository before reading deleted trees. Loose-object deletion now handles read-only files, retries, and missing files.

Priority: ➖ Normal

Estimated code review effort: 4 (Complex) | ~60 minutes

Change: Feature

Sequence Diagram(s)

sequenceDiagram
  participant JavaSourceFileGraphBuilder
  participant Java25ParserFactory
  participant JavaParser
  JavaSourceFileGraphBuilder->>Java25ParserFactory: createJava25Parser()
  Java25ParserFactory-->>JavaSourceFileGraphBuilder: Java25Parser or empty Optional
  JavaSourceFileGraphBuilder->>JavaParser: Build standard parser when factory result is empty
Loading

Merge Risk: 🔵 Low · up to 15c6b

Java 25 support may be mergeable, but the parser plan and a regression test still need owner confirmation before these earlier concerns can be closed.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 61.11% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 126 functions across 26 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the main change: adding Java 25 support. The draft label is additional status information but does not make the title unclear.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@jimbethancourt
jimbethancourt marked this pull request as ready for review September 22, 2026 01:25
devin-ai-integration[bot]

This comment was marked as resolved.

coderabbitai[bot]

This comment was marked as resolved.

devin-ai-integration[bot]

This comment was marked as resolved.

Co-authored-by: devin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com>
@jimbethancourt

Copy link
Copy Markdown
Collaborator Author

@coderabbitai help

@coderabbitai

coderabbitai Bot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

CodeRabbit commands

These commands are invoked using PR/Issue comments.

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai review --preview-config to test the unmerged CodeRabbit configuration on a draft PR. The requester must have repository write access; preview results are non-authoritative.
  • @coderabbitai rate limit to show your current review rate limit status.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai track in a human-authored review thread to track the original finding until CodeRabbit verifies it is fixed.
  • @coderabbitai fixed in a tracked review thread to verify the current code against the original finding.
  • @coderabbitai evaluate custom pre-merge check --instructions <custom-checks-instructions> --name <custom-checks-title> [--mode <error|warning>] to validate the custom pre-merge checks instructions. Defaults to error when --mode is omitted.
  • @coderabbitai ignore pre-merge checks to override pre-merge checks and get an approval on PR.
  • @coderabbitai run pre-merge checks to run pre-merge checks on the pull request.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai emit path instructions to emit generated path-specific review instructions for this repository.
  • @coderabbitai generate project vocabulary to list vocabulary that is specific to this repository.
  • @coderabbitai resolve merge conflict to automatically resolve merge conflicts.
  • @coderabbitai autofix to automatically fix issues in the current review thread, or all unresolved review comments when used in the PR conversation.
  • @coderabbitai autopilot stop to stop Autopilot for this PR.
  • @coderabbitai fix-ci to automatically fix failing CI checks in a stacked pull request.
  • @coderabbitai fix-ci commit to automatically fix failing CI checks by committing fixes to the current branch.
  • @coderabbitai resolve to resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai generate configuration to create a PR that adds the current resolved configuration as .coderabbit.yaml (or show it if already present).
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore or @coderabbit ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit configuration file (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • You can also validate your configuration using the online YAML validator.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, support, documentation and community

  • Visit our status page to check the current availability of CodeRabbit.
  • Create a ticket on our support page for assistance with any issues or questions.
  • Visit our documentation site for detailed information on how to use CodeRabbit.
  • Join our Discord community to connect with other users and get help from the community.
  • Follow us on X/Twitter for updates and announcements.

@jimbethancourt

Copy link
Copy Markdown
Collaborator Author

@coderabbitai full review

@coderabbitai

coderabbitai Bot commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor
✅ Action performed

Full review finished.

coderabbitai[bot]

This comment was marked as resolved.

@coderabbitai

coderabbitai Bot commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

🤖 Completed: Fix CodeRabbit issues in PR #218 — View commit 4a8d324

coderabbitai[bot]

This comment was marked as resolved.

@coderabbitai

coderabbitai Bot commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

🤖 Completed: Fix pre-merge checks in PR #218 — View commit 15c6bc9

…lpers; remove stale parser configuration documentation
@coderabbitai

coderabbitai Bot commented Sep 23, 2026

Copy link
Copy Markdown
Contributor

Note

Unit test generation is a beta feature. Expect some limitations and changes as we gather feedback and continue to improve it.


Generating unit tests... This may take up to 20 minutes.

@coderabbitai

coderabbitai Bot commented Sep 23, 2026

Copy link
Copy Markdown
Contributor

🤖 Coding Agent task started for unit test generation.

…s/696753a2

Add tests for Java 25 parser fallback and CycleRanker graph generation
@jimbethancourt jimbethancourt changed the title #190 Add Java 25 Support - DRAFT PR #190 Add Java 25 Support Sep 23, 2026
@jimbethancourt
jimbethancourt merged commit 18e4000 into main Sep 23, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant