Repository navigation
fix(core): ignore late EPIPE from hook stdin - #360
Merged
Merged
Conversation
filipeforattini
enabled auto-merge (squash)
September 22, 2026 23:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
HookV2tests fail intermittently under parallel CI with an uncaughtEPIPE: broken pipe, write. The handlers in those tests (like many real hooks) exit without reading stdin.Cause
AppProcess.runpasses the hook input as stdin; Effect'sNodeChildProcessSpawnerwrites it through a sink that listens for errors only while attached. When the child exits first, the pipe closes and the pending write fails with EPIPE after the sink stopped listening, so it escapes as an uncaught error: the running test fails, and in production the error surfaces from a hook that simply ignored its input.Fix
Patch
@effect/platform-node-shared@4.0.0-beta.83to attach a no-operrorlistener on the child's stdin before wiring the sink. The sink still reports errors while it is attached; only a late one is kept from escaping.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.