[deprecation] Deprecate AddInterfaceByTraitRector - #8346
Merged
Conversation
TomasVotruba
force-pushed
the
deprecate-add-interface-by-trait-rector
branch
from
August 10, 2026 22:13
ec5511b to
4144291
Compare
TomasVotruba
enabled auto-merge (squash)
August 10, 2026 22:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pairing a trait with an interface is specific to a single project or package. In practice the mapping needs extra conditions - only for classes in a certain namespace, only when the trait is used directly, only when a matching method exists - none of which a plain
trait => interfacemap can express. A custom rule is a better fit.The rule is not part of any set - neither in
rector-srcconfig/set/, nor inrector-symfony,rector-doctrine,rector-phpunit,rector-laravelordrupal-rector.What the rule did:
The class carried an
@api used in rector-doctrinenote, butrector-doctrinehas no reference to it anymore, so the tag was stale and is dropped.Follows the same shape as the recently deprecated rules -
DeprecatedInterface,refactor()throws, tests removed.