Rewrote testing for the cache variant of the AutoRefresh() and AutoRefreshOnObservable() operators,... - #1101
Merged
Conversation
JakenVeina
force-pushed
the
enhancements/cache-auto-refresh-modernization
branch
from
May 29, 2026 06:01
3450986 to
ada5983
Compare
dwcullop
approved these changes
May 29, 2026
dwcullop
left a comment
dwcullop
left a comment
Member
There was a problem hiding this comment.
Minor nit but looks good to me.
| item4.HasObservers.Should().BeTrue("adding an item should invoke its reevaluator and subscribe to it"); | ||
| item1.HasObservers.Should().BeTrue("the item was not removed from the source"); | ||
| item3.HasObservers.Should().BeTrue("the item was not removed from the source"); | ||
| } |
Member
There was a problem hiding this comment.
This test stops after asserting item4.HasObservers == true, but never verifies that the new reevaluator's notifications actually flow through end-to-end. A regression where the operator subscribes to the new item's reevaluator but mishandles the resulting notification (wrong key, dropped Refresh, etc.) would slip through. Consider adding ++item4.Value followed by an assertion that the next recorded changeset contains a Refresh for item4.
JakenVeina
force-pushed
the
enhancements/cache-auto-refresh-modernization
branch
from
May 30, 2026 00:25
67ee820 to
e57d6d3
Compare
JakenVeina
force-pushed
the
enhancements/cache-auto-refresh-modernization
branch
from
May 30, 2026 00:26
e57d6d3 to
ef204b5
Compare
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…in accordance with #1014, and in a preliminary effort to resolve #1099.