test(sum): add more sum tests - #1071
Merged
Merged
Conversation
JakenVeina
requested changes
Mar 20, 2026
JakenVeina
left a comment
JakenVeina
left a comment
Collaborator
There was a problem hiding this comment.
Looks solid, overall. A few nitpicks, and a few suggested new tests/test cases.
giard-alexandre
force-pushed
the
tests/sum
branch
from
May 19, 2026 02:31
6d4c9cf to
4f4532e
Compare
Contributor
Author
|
Alright sorry for the extended delay in getting this pushed out, long story but I moved countries so free time was at a premium. @JakenVeina Everything mentioned above should have been addressed, I'll let you resolve the conversations if it's done to your liking! |
giard-alexandre
force-pushed
the
tests/sum
branch
from
June 15, 2026 15:02
4802a94 to
08abaa7
Compare
JakenVeina
approved these changes
Jun 18, 2026
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should address the first 3 bullet points in #1031 (comment)