Repository navigation
Restore RCTBridge enqueueJSCall compatibility - #59938
Merged
meta-codesync[bot] merged 1 commit intoNov 12, 2026
Merged
Conversation
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this in D131220385. |
Restore the four-argument enqueueJSCall declaration and compatibility stub used by external libraries such as react-native-firebase. The functional implementation remains on RCTBridgeProxy and forwards calls to RCTCallableJSModules.
cipolleschi
force-pushed
the
cipolleschi/revert-rctbridge-public-api-removal
branch
from
November 12, 2026 14:42
1d9cb80 to
017460f
Compare
javache
approved these changes
Nov 12, 2026
javache
left a comment
Contributor
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
Collaborator
|
This pull request was successfully merged by @cipolleschi in aedc2e7 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Restores only the four-argument RCTBridge selector enqueueJSCall:method:args:completion: that was removed by #59429.
@react-native-firebase/app uses this selector in RNFBRCTEventEmitter to forward native Firebase events to RCTDeviceEventEmitter. Its iOS nightly build fails with:
RCTBridgeProxy still implements the selector and forwards calls to RCTCallableJSModules. This restores source compatibility without bringing back the other removed bridge APIs or the skipped logging tests.
Failing nightly job: https://github.com/react-native-community/nightly-tests/actions/runs/43015178202/job/130504459789
Changelog:
[IOS] [FIXED] - Restore RCTBridge enqueueJSCall compatibility for external libraries
Test Plan: