Repository navigation
Store visual baseline images once by content hash - #59581
Merged
Merged
Conversation
meta-cla
Bot
added
the
CLA Signed
robhogan
force-pushed
the
robhogan/visual-cas-baselines
branch
from
November 10, 2026 15:37
9b0d0ae to
63e046b
Compare
robhogan
marked this pull request as ready for review
November 10, 2026 15:37
facebook-github-tools
Bot
added
the
Shared with Meta
Every push to main uploads a full copy of every screenshot under its own commit, ~3.5MB a push, so storage grows with pushes rather than with visual changes. Baseline images are now stored once at `blobs/<sha256>.png`, and each commit's manifest (marked `imageStore: 'blobs'`) refers to them by hash. A push only uploads its manifests and any images not already in `blobs/`. Older baselines without `imageStore` are still read from their per-commit paths. Changelog: [Internal]
robhogan
force-pushed
the
robhogan/visual-cas-baselines
branch
from
November 12, 2026 14:18
63e046b to
00b84c5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every push to
maincurrently uploads a full copy of every baseline screenshot (~3.5MB, ~100 objects), even with no visual change.This stores each image once at
blobs/<sha256>.png, with each commit's manifest referring to images by hash, so a push only uploads its manifests and any new images. Older baselines are still read from their per-commit paths, so there's nothing to migrate.Changelog: [Internal]
Test plan:
New unit tests. Checked against the real bucket that an existing baseline still resolves from its old path, and that a missing blob is detected.