Skip to content

Fix Android URL keyboard input type - #58505

Closed
dajiaohuang wants to merge 1 commit into
react:mainfrom
dajiaohuang:fix/58380-url-input-type
Closed

dajiaohuang wants to merge 1 commit into
react:mainfrom
dajiaohuang:fix/58380-url-input-type

Conversation

@dajiaohuang

@dajiaohuang dajiaohuang commented Sep 13, 2026

Copy link
Copy Markdown
Contributor

Summary

Fixes #58380. Include TYPE_CLASS_TEXT when resolving keyboardType=url so Android receives a valid text input class and the existing property test covers the regression.

Changelog:

[Android] [Fixed] - Restore the text input class for URL keyboard types.

Test Plan

  • ./gradlew :packages:react-native:ReactAndroid:test --tests com.facebook.react.views.textinput.ReactTextInputPropertyTest --no-daemon (blocked locally: Android SDK environment variables and SDK are unavailable).
  • git diff --check (passed).

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 13, 2026
@dajiaohuang

Copy link
Copy Markdown
Contributor Author

Updated the PR description with the required ## Changelog: heading and [Android] [Fixed] entry.

@facebook-github-tools facebook-github-tools Bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Sep 13, 2026
@meta-codesync

meta-codesync Bot commented Sep 14, 2026

Copy link
Copy Markdown

@javache has imported this pull request. If you are a Meta employee, you can view this in D119944050.

@cortinico cortinico left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review automatically exported from Phabricator review in Meta.

@meta-codesync meta-codesync Bot closed this in 0ca5cec Sep 15, 2026
@meta-codesync meta-codesync Bot added the Merged This PR has been merged. label Sep 15, 2026
@meta-codesync

meta-codesync Bot commented Sep 15, 2026

Copy link
Copy Markdown

@javache merged this pull request in 0ca5cec.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

keyboardType="url" on Android produces an inputType with no class, so the IME is never told what the field accepts

2 participants