Build fails for Xcode 15 Beta 1 (and Beta 7)

[below]

Description

When building with Xcode 15 Beta 1, building fails with a C++ issue in boost:

› Compiling react-native Pods/RCT-Folly » json.cpp

❌  (ios/Pods/boost/boost/container_hash/hash.hpp:131:33)

  129 | #else
  130 |         template <typename T>
> 131 |         struct hash_base : std::unary_function<T, std::size_t> {};
      |                                 ^ no template named 'unary_function' in namespace 'std'; did you mean '__unary_function'?
  132 | #endif
  133 | 
  134 |         struct enable_hash_value { typedef std::size_t type; };

Apparently, boost 1.8x does not have this issue and builds correctly. However, react-jsi currently does not work with boost 1.8x due to breaking changes.

React Native Version

0.71.8

Output of npx react-native info

>> npx react-native info
info Fetching system and libraries information...
System:
    OS: macOS 13.4
    CPU: (10) arm64 Apple M1 Pro
    Memory: 124.09 MB / 32.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 19.4.0 - /opt/homebrew/bin/node
    Yarn: 1.22.19 - /opt/homebrew/bin/yarn
    npm: 9.6.5 - /opt/homebrew/bin/npm
    Watchman: Not Found
  Managers:
    CocoaPods: 1.12.1 - /opt/homebrew/lib/ruby/gems/3.1.0/bin/pod
  SDKs:
    iOS SDK:
      Platforms: DriverKit 23.0, iOS 17.0, macOS 14.0, tvOS 17.0, watchOS 10.0
    Android SDK: Not Found
  IDEs:
    Android Studio: 2022.1 AI-221.6008.13.2211.9619390
    Xcode: 15.0/15A5160n - /usr/bin/xcodebuild
  Languages:
    Java: javac 19 - /usr/bin/javac
  npmPackages:
    @react-native-community/cli: Not Found
    react: 18.2.0 => 18.2.0 
    react-native: 0.71.8 => 0.71.8 
    react-native-macos: Not Found
  npmGlobalPackages:
    *react-native*: Not Found

Steps to reproduce

• Prerequisite: On a machine running macOS, ensure that Xcode 15 is installed
• Download or clone this Sample
• cd react-Xcode15Bug
• npm install && (cd ios && pod install)

Then either:

• yarn ios

Or

• xed ios and build with Xcode

Snack, code example, screenshot, or link to a repository

https://github.com/below/react-Xcode15Bug

[Advait1306]

facing the same issue.

[below]

facing the same issue.

Thanks you for confirming reproducibility

[Armanoide]

what happening

unary_function and binary_function are no longer provided in C++17 and newer Standard modes. They can be re-enabled with _LIBCPP_ENABLE_CXX17_REMOVED_UNARY_BINARY_FUNCTION.

release note xcode 15

What must be done

all library must update their code to use std::function & std::bind instead of unary_function

Workaround

• Select Pods > Build Settings > In section Apple Clang - Preprocessing > under Macro section
• add in release & debug _LIBCPP_ENABLE_CXX17_REMOVED_UNARY_BINARY_FUNCTION

tested on Xcode 15 with react-native 0.71.7

[below]

Thank you @Armanoide for pointing this out. In production, this will usually be have to be done via a post-install script in the Podfile, as the Pods are often re-generated.

The other workaround is to patch hash.hpp locally

[Armanoide]

Thank you @Armanoide for pointing this out. In production, this will usually be have to be done via a post-install script in the Podfile, as the Pods are often re-generated.

The other workaround is to patch hash.hpp locally

you're right @below to notice that Pods is re-generated.
To complete answer this should be added in podfile

  post_install do |installer|
      installer.pods_project.targets.each do |target|
        target.build_configurations.each do |config|
          config.build_settings['GCC_PREPROCESSOR_DEFINITIONS'] ||= ['$(inherited)', '_LIBCPP_ENABLE_CXX17_REMOVED_UNARY_BINARY_FUNCTION']
        end
      end
  end

[cipolleschi]

@Armanoide thanks so much for the work around. We will bake this into our Cocoapods scripts... or if you have time and you want to open a PR, that's very welcome! :D

[Armanoide]

@Armanoide thanks so much for the work around. We will bake this into our Cocoapods scripts... or if you have time and you want to open a PR, that's very welcome! :D

i didn't have time today unfortunately but some one did 37758.
It will be soon in the next version of RN 📦

[tido64]

Do we have a separate task for upgrading Boost to a version that doesn't use std::unary_function? I would imagine that we won't be able to even turn this on in a future version.

[below]

@tido64 As of my quick research, boost 1.8.x no longer uses std::unary_function. And yes, this would be the preferable solution to setting options in the Podfile

[tido64]

@tido64 As of my quick research, boost 1.8.x no longer uses std::unary_function. And yes, this would be the preferable solution to setting options in the Podfile

Had a quick look myself. std::unary_function was removed in 2019, but Boost didn't bump ContainerHash until last December 😢