missing autoCompleteType value for new password

[thilonel]

Description:
The autoCompleteType is missing the AUTOFILL_HINT_NEW_PASSWORD value, which would help the users when signing up to a service tremendously.

I believe it should be added ad Libraries/Components/TextInput/TextInput.js#L310

React Native version:

I'm on 0.60.5 at the moment, but I guess it would be useful for all versions.

PS: I know that this is not really a bug, but I haven't found the proper way to submit a feature request.

[safaiyeh]

Hi @thilonel, if you don't got the time to send a PR for this I can take it on.

[thilonel]

I'd appreciate the help @safaiyeh

[safaiyeh]

@thilonel I added the missing type; however, since there a bunch more missing types missing. I'll add them all in one go.

You can track it here: #28008

[safaiyeh]

One question I have, maybe @dulmandakh, @JoshuaGross, or @TheSavior can answer.

This introduces the androidx.autofill:autofill:1.0.0 dependency (added to the PR branch). Is there any concern about that?

[safaiyeh]

Another thing, Android's setAutofillHints API takes an array of strings. Right now we are only supporting 1 hint type. This would be a breaking change; however, how viable would be:

1. Creating an enum of all the hints, verbatim to the strings HintConstants is for example AUTOFILL_HINT_EMAIL_ADDRESS is just string emailAddress, to avoid the manual if statements.

enum TextInputAutofillHints {
  emailAddress = 'emailAddress'
  ...
}

2. Refactor TextInput.setTextContentType to simple set the string array. This can include being more verbose with the method name to setAutoCompleteHints. Plan could be deprecate setTextContentType to not break apps and introduce the new prop. The prop is autoCompleteType which is all good, misunderstood the code 😁

[dulmandakh]

Dependency addition requires some work on FB side, and it might take a while. Feel free to create a PR, and I'll be happy to review it.

[stale]

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may also label this issue as a "Discussion" or add it to the "Backlog" and I will leave it open. Thank you for your contributions.

[thilonel]

Hello @safaiyeh! I see you have a draft PR for this! How is that going? :)

[safaiyeh]

Hi @thilonel sorry for the delay, I haven't had time to check it out. I can pick it back up again.