Dimensions.get('window').height returns wrong height on Android with notch

[onitzschke]

🐛 Bug Report

Dimensions.get('window').height returns wrong height on Android with notch
Device: Android One Mi A2 Lite

Environment

React Native Environment Info:
System:
OS: macOS 10.14.3
CPU: (12) x64 Intel(R) Core(TM) i7-8850H CPU @ 2.60GHz
Memory: 1013.34 MB / 16.00 GB
Shell: 5.3 - /bin/zsh
Binaries:
Node: 11.6.0 - /usr/local/bin/node
Yarn: 1.7.0 - /usr/local/bin/yarn
npm: 6.8.0 - /usr/local/bin/npm
Watchman: 4.9.0 - /usr/local/bin/watchman
SDKs:
Android SDK:
API Levels: 18, 23, 25, 26, 27, 28
Build Tools: 19.1.0, 20.0.0, 21.1.2, 22.0.1, 23.0.1, 23.0.2, 23.0.3, 24.0.0, 24.0.1, 24.0.2, 24.0.3, 25.0.0, 25.0.1, 25.0.2, 25.0.3, 26.0.0, 26.0.1, 26.0.2, 26.0.3, 27.0.0, 27.0.1, 27.0.2, 27.0.3, 28.0.0, 28.0.0, 28.0.0, 28.0.1, 28.0.2, 28.0.3
System Images: android-21 | Intel x86 Atom, android-21 | Google APIs Intel x86 Atom, android-23 | Google APIs Intel x86 Atom, android-23 | Google APIs Intel x86 Atom_64, android-25 | Google APIs ARM EABI v7a, android-27 | Google APIs Intel x86 Atom, android-28 | Google Play Intel x86 Atom, android-28 | Google Play Intel x86 Atom_64
IDEs:
Android Studio: 3.3 AI-182.5107.16.33.5264788
Xcode: /undefined - /usr/bin/xcodebuild
npmPackages:
react: 16.8.3 => 16.8.3
react-native: ^0.58.5 => 0.58.5
npmGlobalPackages:
create-react-native-app: 2.0.2
react-native-cli: 2.0.1
react-native-git-upgrade: 0.2.7

[hramos]

Can you provide more information? What value did the API return vs what was expected, for example.

[onitzschke]

@hramos
Xiaomi Mi A2 lite:
Dimensions.get('window').height) => 681
Dimensions.get('screen').height) => 760
StatusBar.currentHeight => 31
Google Pixel 3:
Dimensions.get('window').height) => 737.4545454545455
Dimensions.get('screen').height) => 785.4545454545455
StatusBar.currentHeight => 24

Expect Dimensions.get('window').height) === 705 on Xiaomi Mi A2 lite to get the same Layout as on Google Pixel 3.

[grabbou]

I believe this is related to issues with Dimensions.get('window') that I outlined here: #14887 (comment)

[terryttsai]

Hi I'm seeing the same issue. Dimensions.get('window').height returns the wrong dimensions for me as well on my Essential Phone.

Dimensions.get('screen').height: 853.3333333333334
Dimensions.get('window').height: 759.6666666666666

So I took a screenshot and measured out the pixels. I measured the soft menu bar to be 48 logical pixels. So I expect Dimensions.get('window').height to return 853.333 - 48 = 805.333 but instead I get 759.666. I don't subtract the status bar height because according to the docs, Dimensions.get('window').height should include the status bar height if the status bar is translucent, which it is.

[ouabing]

Same issue on Mi 8 Lite.

[Martijnkerr]

Issue is on the new Samsung s10 model too.