Skip to content

Navigator navigationBar renders at bottom of screen #1278

Description

@esauter5

I just implemented a Navigator component with a custom navigationBar. When it renders, the navBar renders at the bottom of the screen, but otherwise renders correctly. I noticed that this is because in the code, navBar renders after the scene: https://github.com/facebook/react-native/blob/master/Libraries/CustomComponents/Navigator/Navigator.js#L1318-L1321

I noticed that Navigator.NavigationBar gets around this by setting the navBar component to position: absolute (https://github.com/facebook/react-native/blob/master/Libraries/CustomComponents/Navigator/NavigatorNavigationBar.js#L190-L195)

Would it make sense to have the navbar render first so that it was at the top by default? I can turn open a PR if so.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions