Skip to content

Update Screen-Tracking.md - #545

Merged
grabbou merged 2 commits into
react-navigation:masterfrom
thurt:patch-4
Mar 2, 2017
Merged

grabbou merged 2 commits into
react-navigation:masterfrom
thurt:patch-4

Conversation

@thurt

@thurt thurt commented Mar 2, 2017

Copy link
Copy Markdown

updates names in the onNavigationStateChange example function

updated names in the onNavigationStateChange example function
@grabbou

grabbou commented Mar 2, 2017

Copy link
Copy Markdown

Why such change? The function is called in componentDidUpdate meaning it receives previous and current state (after update), not current and next.

@thurt

thurt commented Mar 2, 2017

Copy link
Copy Markdown
Author

will update

@grabbou

grabbou commented Mar 2, 2017

Copy link
Copy Markdown

Thanks!

@grabbou
grabbou merged commit 99583d2 into react-navigation:master Mar 2, 2017
@nihgwu

nihgwu commented Mar 2, 2017

Copy link
Copy Markdown

I just want to send a PR to revise this 😂 , but there is still another issue so a PR is on the way

@nihgwu

nihgwu commented Mar 2, 2017

Copy link
Copy Markdown

there you go #549

lintonye added a commit to lintonye/react-navigation that referenced this pull request Mar 9, 2017
* master: (21 commits)
  move from react-native-drawer-layout to react-native-drawer-layout-polyfill
  Make TabNavigator code example formatting consistent (react-navigation#462)
  screen props warning removed
  Fix typo (react-navigation#554)
  Change <Header /> layout back to `absolute` (react-navigation#562)
  Update Screen-Tracking.md (react-navigation#549)
  Update Screen-Tracking.md (react-navigation#545)
  Accept tabBar label to be a function (react-navigation#524)
  add import to clarify source of helper (react-navigation#517)
  [Docs] Link every heading automatically (react-navigation#459)
  v1.0.0-beta.6
  Fix TabBarBottom item layout (react-navigation#499)
  fix typo (react-navigation#496)
  Add router prop for the DrawerNavigator content component (react-navigation#487)
  Fix glitches in Header when calling `replace`  (react-navigation#418)
  Add onNavigationStateChange (react-navigation#453)
  Add React.Element support for TabBar/Drawer and fix docs (react-navigation#451)
  fix (react-navigation#454)
  Fix redux documentation (react-navigation#450)
  Remove screen tracking without redux (react-navigation#449)
  ...
sourcecode911 pushed a commit to sourcecode911/react-navigation that referenced this pull request Mar 9, 2020
* Update Screen-Tracking.md

updated names in the onNavigationStateChange example function

* Update Screen-Tracking.md
bartlomiejbloniarz pushed a commit to bartlomiejbloniarz/react-navigation that referenced this pull request Jan 7, 2026
MainStak → MainStack
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants