Getting "No iOS devices connected" for MacOS target on 4.4.0

[kirill-konshin]

Environment

% npx react-native --version
4.4.0

% npx react-native info
info Fetching system and libraries information...
System:
    OS: macOS 10.15.4
    CPU: (12) x64 Intel(R) Core(TM) i9-8950HK CPU @ 2.90GHz
    Memory: 2.89 GB / 32.00 GB
    Shell: 5.7.1 - /bin/zsh
  Binaries:
    Node: 13.9.0 - /usr/local/bin/node
    Yarn: 1.22.0 - ~/.yarn/bin/yarn
    npm: 6.14.2 - ~/.npm-packages/bin/npm
    Watchman: Not Found
  SDKs:
    iOS SDK:
      Platforms: iOS 13.4, DriverKit 19.0, macOS 10.15, tvOS 13.4, watchOS 6.2
    Android SDK: Not Found
  IDEs:
    Android Studio: Not Found
    Xcode: 11.4/11E146 - /usr/bin/xcodebuild
  Languages:
    Python: 2.7.16 - /usr/bin/python
  npmPackages:
    @react-native-community/cli: Not Found
    react: ^16.12.0 => 16.12.0 
    react-native: 0.62.0-rc.5 => 0.62.0-rc.5 
  npmGlobalPackages:
    *react-native*: Not Found

Description

When I run react-native run-ios --device XXX I get:

$ react-native run-ios --device "XXX"
info Found Xcode workspace "XXX.xcworkspace"
error No iOS devices connected.

Where XXX can be found in:

% xcrun instruments -s devices
Known Devices:
XXX [XXX-XXX-XXX-XXX-XXX]

Mac target is enabled:

[thymikee]

cc @alloy

[thymikee]

Should be fixed by #1068

[kirill-konshin]

It’s quite weird why the error is happening because release 4.4.0 had the note “support run-ios on Mac target (Catalyst) (#1024)” :)

Cc @robertying

[robertying]

It’s quite weird why the error is happening because release 4.4.0 had the note “support run-ios on Mac target (Catalyst) (#1024)” :)

Cc @robertying

The device name should be the same with what you set in System Preferences Bluetooth sharing panel.

For example, mine is Rui’s Mac mini. And I can feed —device with “Rui’s Mac mini”

But be aware the single quote for ‘s may be slightly different. Better just copy and paste the Mac device name and wrap it in double quotes.

Let me know if this works for you. :)

[kirill-konshin]

@robertying yes, that's exactly what I've set there... also xcrun instruments -s devices gives me that same name. Yet I still get No iOS devices connected...

[robertying]

Can you console.log(devices) here to debug?

cli/packages/platform-ios/src/commands/runIOS/index.ts

Line 85 in 5503369

Add the code to the corresponding place in node_modules.

[kirill-konshin]

@robertying here you go:

devices [ { udid: 'XXX-XXX-XXX-XXX-XXX', name: 'XXX' } ]
error No iOS devices connected.

Name equals to what I see in xcrun instruments -s devices and in bluetooth as you suggested.

No wonder why it fails: condition is if (devices.length <= 1) {

[robertying]

😅 yeah I just realized this too. The original PR worked as expected. We must have got lost during the review process.

Do you mind submitting another PR to fix this properly? Thank you!

[kirill-konshin]

@robertying I don't mind, but I don't quite know what to put there :))) logic should be — if it's true iOS target, then >=1 otherwise list will never be empty... I presume another target like run-mac would be a better option to distinguish...

[robertying]

Or we could just remove this condition check, since on any Mac, there is at least one device connected (Mac).

Hmm but this could cause confusion if people haven’t started to implement Catalyst...🤔

I don’t really like the idea to separate it with run-mac because Catalyst uses iOS’s UIKit and not Mac’s AppKit.

Maybe we can just drop the check only if the device name passed is the host Mac. If not, we return no iOS device connected.

[kirill-konshin]

Hmm but this could cause confusion if people haven’t started to implement Catalyst...

Exactly.

Maybe we can just drop the check only if the device name passed is the host Mac. If not, we return no iOS device connected.

Makes sense. Just check if device name in args matches the first in the list and go on. Otherwise check if there are more than one.