fix: keep resolver root errors on submit - #13731
Merged
bluebill1049 merged 2 commits intoSep 10, 2026
Merged
bluebill1049 merged 2 commits into
bluebill1049 merged 2 commits into
Conversation
bluebill1049
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
handleSubmit deletes the top-level root error before checking validity, so a resolver reporting a form-level error (for example a cross-field check as errors.root) still submits as valid.
Repro: useForm with a resolver returning { values: {}, errors: { root: { type: 'cross-field', message: '...' } } }. Before this change onValid is called; after, onInvalid is called with the root error intact.
The root cleanup now only runs for built-in validation, where no validation step produces root errors and it clears stale manually set ones (covered by a second test). No behavior change there.
Verification: new tests in handleSubmit.test.tsx fail before and pass after; full jest suite 122 suites / 1348 tests green, tsc and eslint clean.