[cmake] Fix config.h parsing into cmake options - #5844
Merged
Merged
Conversation
Parse SUPPORT_ defines from src/config.h by their actual 0/1 values so CUSTOMIZE_BUILD exposes the correct defaults. Apply INCLUDE_EVERYTHING explicitly when registering dependent options.
Owner
|
@Peter0x44 thanks for the fix! raylib is going at the moment through a private security audit, once critical points get fixed I'll do another release. |
Contributor
Author
|
Do you know when this audit will be finished? |
Owner
|
@Peter0x44 I don't know, it started April 23rd, there are about 20 working items open at the moment, 5 potential vulnerabilities found but only 1 critical ( |
alexmbd
added a commit
to alexmbd/rayplayer
that referenced
this pull request
Sep 4, 2026
- this was fixed with this pr (raysan5/raylib#5844)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The restructuring of config.h broke the fragile regex that cmake was using to parse config.h for its own configurable options. It assumed the presence of an uncommented line was enabled, and ignored parsing 0/1.
This caused major problems, like:
-DSUPPORT_BUSY_WAIT_LOOP=ON
-DSUPPORT_CUSTOM_FRAME_CONTROL=ON
When configuring using cmake by default, with no options explicitly passed.
@raysan5 I would honestly do another release with this fix. It's really bad...