Repository navigation
[VibeDash dc249cfe] Prototype data and duplicate scaffolding remain user-visible - #3
Conversation
|
|
✅ Deploy Preview for zesty-pavlova-54b539 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
rapidstartup
left a comment
There was a problem hiding this comment.
VibeDash Codex Agent Reviewer
The authoritative API integration remains broken for mobile users, and SIP webhook configuration still targets an unreachable handler.
Recommendation: changes requested
Risk: high
Model: gpt-5.6-sol
Findings
- HIGH — Mobile widget loading cannot authenticate
The new widget request uses the token from mobile sign-in, but sign-in always stores the literalmock-jwt-token. The backend validates tokens through Supabase, so every mobile widget request receives 401.
Evidence:mobile/services/api.ts,fetchWidgetslines 14-27;mobile/contexts/AuthContext.tsx,signInlines 54-71;server/middleware/auth.ts,authenticateUserlines 10-20. - MEDIUM — SIP webhook configuration has no reachable handler
WidgetCreator posts configuration to/api/widgets/:id/configure-twilio-webhooks, but Netlify routes this to the widgets function, whose POST branch always attempts widget creation. The matching Express route is never mounted. Consequently SIP widgets are created without automatic webhook configuration.
Evidence:src/components/WidgetCreator.tsx,handleSubmitlines 79-104;netlify/functions/widgets.ts, POST branch lines 64-78;server/routes/widgets.ts, route at lines 35-70;server/index.tslines 62-64 mounts only mobile and Twilio routes.
Validation reviewed
- passed:
git diff --check 6607f7c64f19c00522a26605323c6002afbac6e8..090a7b41991f0a3ecc8b5534285e79e0ffb27d8b— No whitespace errors. - not_run:
npm run build— The sandbox has no npm executable. - not_run:
npm run lint— The sandbox has no npm executable. - not_run:
cd mobile && npm run lint— The sandbox has no npm executable.
This agent does not merge or close tasks; final closure remains with a human.
GitHub would not accept the formal request_changes state (commonly because the reviewer owns the PR), so the recommendation is recorded as a comment.
There was a problem hiding this comment.
VibeDash Codex Agent Reviewer
The authoritative API integration remains broken for mobile users, and SIP webhook configuration still targets an unreachable handler.
Recommendation: changes requested
Risk: high
Model: gpt-5.6-sol
Findings
- HIGH — Mobile widget loading cannot authenticate
The new widget request uses the token from mobile sign-in, but sign-in always stores the literalmock-jwt-token. The backend validates tokens through Supabase, so every mobile widget request receives 401.
Evidence:mobile/services/api.ts,fetchWidgetslines 14-27;mobile/contexts/AuthContext.tsx,signInlines 54-71;server/middleware/auth.ts,authenticateUserlines 10-20. - MEDIUM — SIP webhook configuration has no reachable handler
WidgetCreator posts configuration to/api/widgets/:id/configure-twilio-webhooks, but Netlify routes this to the widgets function, whose POST branch always attempts widget creation. The matching Express route is never mounted. Consequently SIP widgets are created without automatic webhook configuration.
Evidence:src/components/WidgetCreator.tsx,handleSubmitlines 79-104;netlify/functions/widgets.ts, POST branch lines 64-78;server/routes/widgets.ts, route at lines 35-70;server/index.tslines 62-64 mounts only mobile and Twilio routes.
Validation reviewed
- passed:
git diff --check 6607f7c64f19c00522a26605323c6002afbac6e8..090a7b41991f0a3ecc8b5534285e79e0ffb27d8b— No whitespace errors. - not_run:
npm run build— The sandbox has no npm executable. - not_run:
npm run lint— The sandbox has no npm executable. - not_run:
cd mobile && npm run lint— The sandbox has no npm executable.
This agent does not merge or close tasks; final closure remains with a human.
Removed prototype data and duplicate signaling scaffolding; widget data now uses authenticated APIs, while unavailable call history is clearly disabled.
VibeDash task:
dc249cfe-18aa-420c-b1db-0e22d5cdfda7Runner: House Codex —
gpt-5.6-luna/xhighValidation:
git diff --check— Passed.npm run lint— npm is unavailable in the sandbox.npm run build— npm is unavailable in the sandbox.This PR was opened as a draft for human review.