Conversation
…t mosquitto version
This was referenced Sep 25, 2026
randomsync
added a commit
that referenced
this pull request
Sep 27, 2026
* Migrate to the paho-mqtt 2 callback API Construct mqtt.Client with keyword arguments and CallbackAPIVersion.VERSION2, and move the callbacks to the version 2 signatures. Require paho-mqtt>=2.0,<3. CI runs the tests on paho-mqtt 2.0.0 and on the latest 2.x. This is a mechanical port. Keyword names, arguments, error messages and the MQTT v3.1 default of Publish Single and Publish Multiple are unchanged. The loop redesign follows in #45. Based on PR #36 by Luigi Caiffa. Co-authored-by: Luigi Caiffa <luigi.caiffa@scmgroup.com> * Require paho-mqtt 2.1, keep the protocol default an int, document the new connection error text paho-mqtt 2.0.0's Client.protocol property recurses forever, and its loop_stop is the only place that clears _thread. Raise the floor to 2.1 and move the CI lower-bound leg to 2.1.0. Under paho 2, mqtt.MQTTv31 is an IntEnum, so Robot Framework 7 converted the protocol argument of Publish Single and Publish Multiple as an enum and passed non-member values on as strings. Default to a plain int, as with paho 1. Publish Single and Publish Multiple now fail with paho 2's reason text when the broker refuses the connection. Record that in the CHANGELOG as a breaking change. Use ReasonCode.is_failure in the connect and disconnect callbacks, and only add a paho-mqtt requirement in CI for the pinned leg. --------- Co-authored-by: Luigi Caiffa <luigi.caiffa@scmgroup.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm opening this PR to modernize the project's dependencies.
Specifically, I updated the paho-mqtt version to address the breaking changes related to the migration to version 2.
At that point, I also updated the robotframework version.
I ran all the tests as directed and verified that they all passed.
To make the tests green, I had to modify the mosquitto configuration, which in the meantime had modified some of its policies for security reasons.