Repository navigation
Log locked EU5 saves at debug level in watch - #63
Merged
Merged
Conversation
While the game writes a save, it locks the save. The watch command tried to read the save during the write and logged an error, but a later event read the complete save. Thus, each autosave caused an error that the user did not have to fix. Open the save in the watch loop and log a failure to open at debug level. Keep a failure to parse at error level, because a save that opens is complete. Show the full error chain for a failure to parse.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While the game writes a save, it locks the save. The watch command tried to read the save during the write and logged an error, but a later event read the complete save. Thus, each autosave caused an error that the user did not have to fix.
Open the save in the watch loop and log a failure to open at debug level. Keep a failure to parse at error level, because a save that opens is complete. Show the full error chain for a failure to parse.