Skip to content

dust trade size handler - #490

Merged
rouzwelt merged 2 commits into
masterfrom
2026-09-09-dust-trade-size
Sep 23, 2026
Merged

rouzwelt merged 2 commits into
masterfrom
2026-09-09-dust-trade-size

Conversation

@rouzwelt

Copy link
Copy Markdown
Collaborator

Motivation

Solution

Checks

By submitting this for review, I'm confirming I've done the following:

  • made this PR as small as possible
  • unit-tested any new functionality
  • linked any relevant issues or PRs
  • included screenshots (if this involves a front-end change)

@rouzwelt rouzwelt self-assigned this Sep 16, 2026
@coderabbitai

coderabbitai Bot commented Sep 16, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

Next included review available in 38 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: bd21c9b3-8017-4442-b83b-2c89d12002e5

📥 Commits

Reviewing files that changed from the base of the PR and between 2772b6e and 614c4ff.

📒 Files selected for processing (22)
  • config.env.yaml
  • config.example.yaml
  • src/cli/commands/sweep.ts
  • src/config/yaml.test.ts
  • src/config/yaml.ts
  • src/core/modes/index.test.ts
  • src/core/modes/index.ts
  • src/core/modes/router/index.test.ts
  • src/core/modes/router/index.ts
  • src/core/modes/router/simulate.ts
  • src/core/modes/simulator.test.ts
  • src/core/modes/simulator.ts
  • src/core/process/order.test.ts
  • src/core/process/order.ts
  • src/core/process/round.ts
  • src/core/types.ts
  • src/math/index.test.ts
  • src/math/index.ts
  • src/router/sushi/index.test.ts
  • src/router/sushi/index.ts
  • src/state/index.test.ts
  • src/state/index.ts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@rouzwelt
rouzwelt changed the base branch from 2026-09-08-router-update-subscriber to master September 23, 2026 00:22
@rouzwelt
rouzwelt merged commit 12d60da into master Sep 23, 2026
4 of 12 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

@coderabbitai assess this PR size classification for the totality of the PR with the following criterias and report it in your comment:

S/M/L PR Classification Guidelines:

This guide helps classify merged pull requests by effort and complexity rather than just line count. The goal is to assess the difficulty and scope of changes after they have been completed.

Small (S)

Characteristics:

  • Simple bug fixes, typos, or minor refactoring
  • Single-purpose changes affecting 1-2 files
  • Documentation updates
  • Configuration tweaks
  • Changes that require minimal context to review

Review Effort: Would have taken 5-10 minutes

Examples:

  • Fix typo in variable name
  • Update README with new instructions
  • Adjust configuration values
  • Simple one-line bug fixes
  • Import statement cleanup

Medium (M)

Characteristics:

  • Feature additions or enhancements
  • Refactoring that touches multiple files but maintains existing behavior
  • Breaking changes with backward compatibility
  • Changes requiring some domain knowledge to review

Review Effort: Would have taken 15-30 minutes

Examples:

  • Add new feature or component
  • Refactor common utility functions
  • Update dependencies with minor breaking changes
  • Add new component with tests
  • Performance optimizations
  • More complex bug fixes

Large (L)

Characteristics:

  • Major feature implementations
  • Breaking changes or API redesigns
  • Complex refactoring across multiple modules
  • New architectural patterns or significant design changes
  • Changes requiring deep context and multiple review rounds

Review Effort: Would have taken 45+ minutes

Examples:

  • Complete new feature with frontend/backend changes
  • Protocol upgrades or breaking changes
  • Major architectural refactoring
  • Framework or technology upgrades

Additional Factors to Consider

When deciding between sizes, also consider:

  • Test coverage impact: More comprehensive test changes lean toward larger classification
  • Risk level: Changes to critical systems bump up a size category
  • Team familiarity: Novel patterns or technologies increase complexity

Notes:

  • the assessment must be for the totality of the PR, that means comparing the base branch to the last commit of the PR
  • the assessment output must be exactly one of: S, M or L (single-line comment) in format of: SIZE={S/M/L}
  • do not include any additional text, only the size classification
  • your assessment comment must not include tips or additional sections
  • do NOT tag me or anyone else on your comment

@linear

linear Bot commented Sep 23, 2026

Copy link
Copy Markdown

RAI-2573

This branch is being deployed

1 in progress deployment
preview — 614c4ffd Deployed Sep 23, 2026 by github-actions[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant