Skip to content

Replace Merkle trees with lists - #234

Merged
pirapira merged 2 commits into
raiden-network:masterfrom
pirapira:remove-merkle
Jul 3, 2019
Merged

pirapira merged 2 commits into
raiden-network:masterfrom
pirapira:remove-merkle

Conversation

@pirapira

Copy link
Copy Markdown
Contributor

following the recent change to the contracts
raiden-network/raiden-contracts#1062

@LefterisJP

Copy link
Copy Markdown
Contributor

Why do we have the contract sources duplicated in the spec?

@pirapira

Copy link
Copy Markdown
Contributor Author

@LefterisJP for generating API docs.

@LefterisJP

Copy link
Copy Markdown
Contributor

So for this page? https://raiden-network-specification.readthedocs.io/en/latest/smart_contracts.html

I know it's a big change and not something to focus on now but perhaps it would make sense to have the raiden-contracts repo generate their own documentation and simply link to it at the contracts section of raiden spec if it's like this. Duplicating the contracts code all the time is just error prone.

@pirapira

Copy link
Copy Markdown
Contributor Author

@LefterisJP I think that's a reasonalbe solution but it's for the team to decide: #235

@pirapira
pirapira requested a review from err508 June 28, 2019 07:49
following the recent change to the contracts
raiden-network/raiden-contracts#1062
@pirapira
pirapira requested a review from czepluch July 3, 2019 12:07

@czepluch czepluch left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address my questions. I just have one thing that I am uncertain about. Other than that it looks good and will approve when you have clarified. Thanks!

Comment thread messaging.rst Outdated
Comment thread messaging.rst Outdated
Comment thread messaging.rst Outdated

@czepluch czepluch left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the changes. Looks good to me.

@pirapira
pirapira merged commit 24b406b into raiden-network:master Jul 3, 2019
@pirapira
pirapira deleted the remove-merkle branch July 3, 2019 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants