Skip to content

fix(deps): patch Nanoid zero-size advisory - #157

Merged
radroid merged 1 commit into
mainfrom
chore/fix-nanoid-zero-size-advisory
Sep 22, 2026
Merged

radroid merged 1 commit into
mainfrom
chore/fix-nanoid-zero-size-advisory

Conversation

@radroid

@radroid radroid commented Sep 22, 2026 •

Copy link
Copy Markdown
Owner

Nanoid remained pinned to 3.3.17, which is vulnerable to an infinite loop in zero-size custom generators even though GitHub had auto-dismissed the repository alert.

Raise the Nanoid 3 override floor to 3.3.18 and re-resolve the lockfile to 3.3.19. pnpm audit --prod no longer reports Nanoid; the remaining findings are the four previously documented accepted exceptions. Frozen lockfile installation and supply-chain policy verification pass.

Generated by GPT-5.6 Sol through the Codex harness.

Summary by CodeRabbit

  • Security

    • Updated Nanoid 3 to version 3.3.18 or later to ensure the application remains above the patched security baseline.
  • Chores

    • Refined dependency safeguards and related maintenance guidance.

@coderabbitai

coderabbitai Bot commented Sep 22, 2026

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: radroid/t3code/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: d57f0545-99e8-4261-84ab-9324cf684925

📥 Commits

Reviewing files that changed from the base of the PR and between dc8a796 and 8df97aa.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (1)
  • pnpm-workspace.yaml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The Nanoid 3 workspace override now requires version ^3.3.18. Its comment now documents the patched floor for the zero-size custom-generator advisory.

Changes

Nanoid override

Layer / File(s) Summary
Update Nanoid 3 override
pnpm-workspace.yaml
The override changed from ^3.3.17 to ^3.3.18. The explanatory comment now references the zero-size custom-generator advisory.

Priority: ➖ Normal

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Suggested reviewers: juliusmarminge

Merge Risk: ⚪ Minimal · up to 8df97

The dependency update addresses the stated Nanoid advisory without introducing an identified merge-blocking risk.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the primary change: patching the Nanoid zero-size advisory. It is concise and specific.
Description check ✅ Passed The description explains the Nanoid vulnerability, the dependency update, the lockfile result, and validation results. It does not use the template headings or include the checklist, but the required …
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@radroid
radroid merged commit af71cf6 into main Sep 22, 2026
2 checks passed
@radroid
radroid deleted the chore/fix-nanoid-zero-size-advisory branch September 22, 2026 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant