fix(coil): scripts typecheck passes on effect rc.115 - #154
Conversation
The sync merge (#153) bumped effect to rc.115, which renamed the unstable CLI helpers Flag.string/Flag.boolean to Flag.String/Flag.Boolean. verify-mac-signature still used the old names, so the scripts package failed typecheck on main and the release was withheld. sync-upstream.test.ts also tripped the nodeBuiltinImport diagnostic; it now carries the same per-file opt-out header upstream puts on its own scripts tests that shell out to real processes. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: radroid/t3code/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe changes update CLI flag constructor names in the macOS signature verification command and add a diagnostic suppression directive to the upstream synchronization integration test. Runtime behavior remains unchanged. ChangesCLI flag API update
Integration test diagnostic
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Bug fix 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Main has been red since the sync merge (#153) landed: the
scriptspackage fails typecheck, and because the release workflow gates on green CI, no build has shipped since0.0.40-coil.138.Two fork-owned files under
scripts/coilwere the cause:verify-mac-signature.tsusedFlag.string/Flag.boolean. Effect rc.115 renamed these toFlag.String/Flag.Boolean(upstream'sapps/server/scripts/cli.tsalready uses the new names).sync-upstream.test.tsimportsnode:fs/node:child_process/node:path, andnodeBuiltinImportis an error intsconfig.base.json. It now carries the same first-line@effect-diagnostics nodeBuiltinImport:offheader upstream puts on its own scripts tests that shell out to real processes.Verified locally at rc.115:
tsc --noEmitinscriptsexits 0 with noerror TSlines,coil/sync-upstream.test.tsandcoil/mac-signature.test.tspass, lint and format are clean.Written by Claude Fable 5.1 via Claude Code.
🤖 Generated with Claude Code
Summary by CodeRabbit
Chores
Tests