Repository navigation
refactor: Remove unused dual-file transcription mode - #4
Merged
Merged
Conversation
Remove dead code paths that were superseded by the multichannel pipeline: - transcribeMeetingFiles() - public method that was never called - transcribeWithAssemblyAI() - private implementation for dual API calls - cleanupAudioFiles() - helper only used by the removed methods The multichannel pipeline (merged stereo, single API call) is now the only path for mic+system recordings, while transcribeToIntermediateResult handles mic-only recordings. This removes ~200 lines of redundant code. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
r3dbars
added a commit
that referenced
this pull request
Mar 18, 2026
Remove dead code paths that were superseded by the multichannel pipeline: - transcribeMeetingFiles() - public method that was never called - transcribeWithAssemblyAI() - private implementation for dual API calls - cleanupAudioFiles() - helper only used by the removed methods The multichannel pipeline (merged stereo, single API call) is now the only path for mic+system recordings, while transcribeToIntermediateResult handles mic-only recordings. This removes ~200 lines of redundant code. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: justinbetker <Justin.betker@jamf.com> Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
r3dbars
added a commit
that referenced
this pull request
Apr 7, 2026
perf: split agent lock, native Swift chat, bump debounce threshold
r3dbars
added a commit
that referenced
this pull request
Apr 7, 2026
perf: split agent lock, native Swift chat, bump debounce threshold
Merged
4 of 6 tasks
This was referenced Jun 16, 2026
This was referenced Jun 25, 2026
11 of 14 tasks
This was referenced Sep 25, 2026
This was referenced Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
transcribeMeetingFiles()- public method that was never called externallytranscribeWithAssemblyAI()- private implementation that sent mic and system audio as separate API callscleanupAudioFiles()- helper only used by the removed methodsContext
The multichannel pipeline was added in #73830d2 as a more efficient approach:
The
TranscriptionTaskManagerwas refactored to use only:transcribeMultichannel()for mic+system recordingstranscribeToIntermediateResult()for mic-only recordingsThe old dual-file code path was left in place but never invoked, making it dead code.
Test plan
xcodebuild -scheme Murmur)🤖 Generated with Claude Code