Repository navigation
Meetings: record the diarizer and voiceprint model that actually ran - #1920
Merged
Merged
Conversation
diarization_engine was hardcoded to pyannote_offline, so every Nemotron meeting since #1887 said pyannote. The pipeline now reads the diarizer's activeRunDescriptor right before it diarizes (a Nemotron load fallback reads pyannote) and the formatter writes nemotron_offline / pyannote_offline / none, plus an optional voiceprint_model key. The '+ PyAnnote pipeline' log line and the raw footer name the real backend. CaptureKit and MCP surface voiceprint_model; older files read unchanged.
7 of 8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong
Every meeting saved since Nemotron became the default (#1887) says
diarization_engine: pyannote_offline. The formatter had that value hardcoded. The pipeline logUsing local Parakeet V2 + PyAnnote pipelineand the raw footer+ PyAnnote (local)were hardcoded too.I checked the 2026-09-29 meetings in the local logs: both runs (14:08 and 14:24 UTC) used Nemotron
fast128with theredimnet2-b4embedder. No pyannote fallback happened, so the files are wrong about their own engine.What changed
DiarizationEnginegetsactiveRunDescriptor(DiarizationRunDescriptor: backend + voiceprint model id). The protocol default is pyannote with no model, so existing conformers and test stubs keep working.DiarizationServicebuilds it fromactiveBackend, so a Nemotron load failure reads pyannote. The voiceprint model is the injected embedder's id, else Nemotron's fallback embedder, else pyannote's nativewespeaker.TranscriptionResult.diarization.diarization_engine: nemotron_offline | pyannote_offline | none.nonemeans no diarizer ran, e.g. a mic-only meeting without split. It also writes an optional quotedvoiceprint_model: "redimnet2-b4".backendtoo, so a fallback shows up in the logs.voiceprintModel: String?. MCPenginesgainsvoiceprint_model, left out of the JSON when absent.TranscriptValidatoraccepted onlypyannote_offline, so it would have failed every correct Nemotron file. It now accepts all three values and still rejects unknown ones.docs/capture-format.mddocuments the values and the new key. Files saved before 2026-09-29 always saypyannote_offline, so in older files that value should be read as "unknown backend".none.DiarizationBackend.swift.Older transcripts parse as before: no key is required, and unknown values are kept.
Tests
Behavior tests, no source reads:
voiceprint_model.voiceprint_model.Checks
bash check.sh: swift test, CaptureKit/CLI/MCP/QA packages, integration smoke, source pins, test shape, and doc paths all pass. In that run,build.shfailed in 0.4 s because it ran beforebuild-deps;run-tests.shand the e2e smoke failed on the missing source-list entry (fixed in a1386a8). Rerun after the fix:build.sh --no-open✅,run-tests.sh19963/19963 ✅,run-e2e-smoke.sh✅.concurrency-census --checkfails with Sources/UI at 54 against a baseline of 51. This diff touches nothing inSources/UI(the warnings are in MenuBar/Overlay files), so this was already on main./code-reviewpass found nothing, but it ran in the same session that wrote the code. An independent review (codex reviewor a separate thread) is still owed per AGENTS.md.🤖 Generated with Claude Code