Repository navigation
Deflake the Meet-after-Not-now prompt test - #1901
Merged
Merged
Conversation
…a fixed 100 ms The suite waited a fixed ~100 ms for MeetingPromptDetector's async evaluation before asserting a prompt arrived, so a loaded machine could assert first: seen as 'a real Meet tab right after a Not now ... should still prompt — expected 2, got 0' in a full run, passing on rerun. The two waits that expect a prompt now wait until it arrives (up to about 5 s); the final 'no new prompt' check keeps the fixed wait, which a slow runner can't turn red. Other suites in the file share the fixed helper and can flake the same way under heavy load; fixing them for good needs a pending-evaluation hook in the detector, noted in the testing plan. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plan item #2 (zero flakes).
MeetingPromptDetector browser evidence — Not now to a generic prompt does not hide a Meet tabwaited a fixed ~100 ms for the detector's async evaluation before asserting a prompt arrived. In a fullrun-tests.shon a loaded machine it failed ("expected 2, got 0") and passed on rerun.The two waits that expect a prompt now wait until it arrives, up to about 5 s (
waitForPromptEvaluation(until:)). The final "no new prompt" check keeps the fixed wait; a slow runner can only make that one pass, not fail.Not fixed here: other suites in the file share the fixed ~100 ms helper (60 call sites) and can flake the same way under heavy local load (seen at lines 320 and 907 while this machine ran several builds at once; CI has been green). A reliable fix for all of them needs a pending-evaluation hook in
MeetingPromptDetector, a hotspot file, so that's a separate change.Verified:
run-tests.sh --filter MeetingPromptDetectorTests(the fixed suite passes; the other flakes are load-dependent and pass on rerun),check-test-shape.py.🤖 Generated with Claude Code