Repository navigation
feat: Add meeting detection and fix console warnings - #10
Merged
Merged
Conversation
Meeting Detection: - Add MeetingDetector that monitors calendar events and audio activity - Add MeetingDetectedOverlay UI component for recording prompts - Integrate detection with PillStateManager for seamless UX - Add setting toggle to enable/disable meeting detection Console Warning Fixes: - Fix SwiftUI onChange warning by debouncing rapid DisplayStatus updates - Improve CoreAudio cleanup sequence to minimize internal framework warnings - Document expected HALC warnings in SystemAudioCapture and MEMORY.md Also includes: - monitor-recording.sh script for reliability testing 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
r3dbars
added a commit
that referenced
this pull request
Mar 18, 2026
feat: Add meeting detection and fix console warnings
claude Bot
pushed a commit
that referenced
this pull request
Sep 23, 2026
Review item #10. When the mail app can't open a support email, the fallback used NSAlert.runModal(), the pattern 6ca9139 removed from the duplicate-launch notice because a modal loop can keep Stop from running during a capture. Show the same alert's window as a normal floating window and route its buttons to a callback. A second failure while it's up brings the existing one forward. Same copy, same buttons, and the clipboard still only changes on Copy Address. The injectable presentFallback now takes a completion; tests updated to match. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QEji7nWg5mSyPSXzn3eb85
This was referenced Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Meeting Detection Feature
MeetingDetectorclass that monitors:MeetingDetectedOverlayUI component showing "Meeting detected - Record?" promptPillStateManagerfor seamless state transitionsConsole Warning Fixes
onChange(of: DisplayStatus) action tried to update multiple times per frameby debouncing rapid status updates withTask { @MainActor in ... }SystemAudioCaptureto minimize internal framework warningsDocumentation
HALC_ShellObject::SetPropertyData- normal during aggregate device creationthrowing -10877- internal format negotiationAudioObjectRemovePropertyListener- cleanup race condition (harmless)Testing Tools
monitor-recording.shscript for monitoring long recording sessionsTest Plan
🤖 Generated with Claude Code