Stack-validation checklist: re-home click paths onto the 26.8.0 sidebar - #29
Open
nl0 wants to merge 1 commit into
Open
Stack-validation checklist: re-home click paths onto the 26.8.0 sidebar#29nl0 wants to merge 1 commit into
nl0 wants to merge 1 commit into
Conversation
26.8.0 replaces the top navigation bar with a persistent left sidebar (Volumes, Search, Queries, Bookmarks, Ask Qurator, Admin), and Queries moved off the bucket to a global /queries page. Four steps in the smoke test named controls that no longer exist, so a tester following it would stall. - Step 1: Admin is a sidebar item, not a user-id dropdown (upper right). - Step 2: the bucket list is Volumes in the sidebar, not the Q logo; the success check now names the current tab set. - Step 4: Search is a sidebar item, not a top-bar button. - Step 5: Queries is the global /queries page, not a bucket tab.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 26.8.0 catalog shell replaces the top navigation bar with a persistent left
sidebar (Volumes, Search, Queries, Bookmarks, Ask Qurator, Admin) and moves
Queries off the bucket to a workspace-global
/queriespage. Four steps in the5-minute smoke test named controls that no longer exist, so a tester following
it after Monday's release would stall on step 1.
Companion to quiltdata/quilt#5231, which does the same for
docs/.Changes —
test-checklists/general-1-stack-validation.mdAll three P1s from the 26.8.0 docs sweep, plus the one P2 in the same
find-and-replace class (it is the same shell change, and leaving it would have
left the checklist half-fixed).
/queriespage, Athena tab) → Enter and run:"Step 2's success line also now names the current tabs — Overview, Files,
Packages, Workflows — so "tabs are clickable" is checkable rather than
open-ended. The bucket tab formerly called Bucket is now Files, and
there is no longer a Queries tab.
Verified against catalog source, not the audit's paraphrase
Each click path was checked at
quiltdata/quiltorigin/master:catalog/app/containers/Sidebar/Sidebar.tsx(
Volumes:501,Search:513,Queries:525,Bookmarks:543,Ask Qurator:553,Admin:569, admin-gated at :558)./b/*, which is why it replaces thelogo click for "pick a bucket" —
Sidebar.tsx:379-391,urls.buckets().(The logo still links home, but Volumes is the labelled, discoverable route
and the one that stays correct with the
front-doorpreview off.)containers/Bucket/Nav/Nav.tsx:20-38,Nav/Tabs.tsx:50-59./querieswith an Athena subsection at/queries/athena;/b/<bucket>/queriesredirects there —constants/routes.ts:81-112, 277-281and
containers/App/queryRedirects.jsx.elasticsearch-queriesflag off (the default in 26.8.0) the Queriespage renders Athena only and no tab strip, so "the Athena tab" in step 5 is
parenthetical rather than a required click —
containers/Queries/Queries.tsx:75.Found while verifying — NOT fixed here
Step 5's expected result is stale for an unrelated reason. It runs
SHOW TABLESand then says:Per-bucket
*_packages-view/*_objects-viewAthena views were removed inQuilt Platform 1.70 and replaced by the Iceberg
*_package_manifestand*_package_entrytables (seedocs/Catalog/Query.mdanddocs/advanced-features/iceberg-tables.mdin the quilt repo, andrelease-notes/1-70-0-release-notes.mdhere, which documents the removal). Atester on 26.8.0 will not find that view and the sample query will fail.
Left out of this PR deliberately: it is a different change from the shell
re-home, was not in the audited finding set, and the replacement query wants
someone to run it against a live stack rather than be transcribed from docs.
Worth its own PR.
Also deferred
howto-collect-search-cluster-diagnostics.md: documents only theAWS CloudShell/CLI path. 26.8.0 adds an in-catalog trigger at
Admin > Settings > Support Diagnostics (verified:
containers/Admin/Settings/Settings.tsx:437-442). Adding an "Option A:in-catalog" branch is new prose about a new feature and wants someone who has
actually run the in-catalog collector end to end, so it is out of scope for
this mechanical pass.
release-notes/1-71-0-release-notes.md. Flagged as a gap, not fixed: releasenotes are their own deliverable.
1-62-0…1-71-0) still say "navbar", "Buckettab", "Queries tab". Correctly left alone — they are accurate for their own
releases.
🤖 Generated with Claude Code
Greptile Summary
Updates the stack-validation smoke test to follow the 26.8.0 catalog sidebar and workspace-global Queries page.
/queriespage.Confidence Score: 5/5
The PR appears safe to merge with no actionable issue introduced by the changed checklist instructions.
The updated steps consistently replace obsolete controls with the target release’s sidebar routes, while the known stale query expectation predates this navigation-only change and is explicitly deferred.
Important Files Changed
Reviews (1): Last reviewed commit: "Stack-validation checklist: re-home clic..." | Re-trigger Greptile