Skip to content

Stack-validation checklist: re-home click paths onto the 26.8.0 sidebar - #29

Open
nl0 wants to merge 1 commit into
mainfrom
alexei/runbooks-shell-rehome
Open

Stack-validation checklist: re-home click paths onto the 26.8.0 sidebar#29
nl0 wants to merge 1 commit into
mainfrom
alexei/runbooks-shell-rehome

Conversation

@nl0

@nl0 nl0 commented Aug 27, 2026

Copy link
Copy Markdown
Member

The 26.8.0 catalog shell replaces the top navigation bar with a persistent left
sidebar (Volumes, Search, Queries, Bookmarks, Ask Qurator, Admin) and moves
Queries off the bucket to a workspace-global /queries page. Four steps in the
5-minute smoke test named controls that no longer exist, so a tester following
it after Monday's release would stall on step 1.

Companion to quiltdata/quilt#5231, which does the same for docs/.

Changes — test-checklists/general-1-stack-validation.md

All three P1s from the 26.8.0 docs sweep, plus the one P2 in the same
find-and-replace class (it is the same shell change, and leaving it would have
left the checklist half-fixed).

Step Was Now Priority
1. Login and User Management "Click your user id (upper right) → Admin → …" "Click Admin (left sidebar) → Users and Roles → Users" P1
2. Bucket Setup "Click Q logo (upper left) → Select the new bucket" "Click Volumes (left sidebar) → Select the new bucket"; success check now names the tab set P2
4. Search Validation "Click Search button (top bar)" "Click Search (left sidebar)" P1
5. Query Test "Queries tab → Enter and run:" "Queries (left sidebar; the global /queries page, Athena tab) → Enter and run:" P1

Step 2's success line also now names the current tabs — Overview, Files,
Packages, Workflows — so "tabs are clickable" is checkable rather than
open-ended. The bucket tab formerly called Bucket is now Files, and
there is no longer a Queries tab.

Verified against catalog source, not the audit's paraphrase

Each click path was checked at quiltdata/quilt origin/master:

  • Sidebar items and their exact labels — catalog/app/containers/Sidebar/Sidebar.tsx
    (Volumes :501, Search :513, Queries :525, Bookmarks :543,
    Ask Qurator :553, Admin :569, admin-gated at :558).
  • Volumes is the bucket list and owns /b/*, which is why it replaces the
    logo click for "pick a bucket" — Sidebar.tsx:379-391, urls.buckets().
    (The logo still links home, but Volumes is the labelled, discoverable route
    and the one that stays correct with the front-door preview off.)
  • Bucket tabs are Overview, Files, Packages, Workflows —
    containers/Bucket/Nav/Nav.tsx:20-38, Nav/Tabs.tsx:50-59.
  • Queries is /queries with an Athena subsection at /queries/athena;
    /b/<bucket>/queries redirects there — constants/routes.ts:81-112, 277-281
    and containers/App/queryRedirects.jsx.
  • With the elasticsearch-queries flag off (the default in 26.8.0) the Queries
    page renders Athena only and no tab strip, so "the Athena tab" in step 5 is
    parenthetical rather than a required click — containers/Queries/Queries.tsx:75.

Found while verifying — NOT fixed here

Step 5's expected result is stale for an unrelated reason. It runs
SHOW TABLES and then says:

  1. Look for yourcompany-test-bucket_packages-view
  2. Quick metadata query: SELECT * FROM "yourcompany-test-bucket_packages-view" …

Per-bucket *_packages-view / *_objects-view Athena views were removed in
Quilt Platform 1.70 and replaced by the Iceberg *_package_manifest and
*_package_entry tables (see docs/Catalog/Query.md and
docs/advanced-features/iceberg-tables.md in the quilt repo, and
release-notes/1-70-0-release-notes.md here, which documents the removal). A
tester on 26.8.0 will not find that view and the sample query will fail.

Left out of this PR deliberately: it is a different change from the shell
re-home, was not in the audited finding set, and the replacement query wants
someone to run it against a live stack rather than be transcribed from docs.
Worth its own PR.

Also deferred

  • P2 — howto-collect-search-cluster-diagnostics.md: documents only the
    AWS CloudShell/CLI path. 26.8.0 adds an in-catalog trigger at
    Admin > Settings > Support Diagnostics (verified:
    containers/Admin/Settings/Settings.tsx:437-442). Adding an "Option A:
    in-catalog" branch is new prose about a new feature and wants someone who has
    actually run the in-catalog collector end to end, so it is out of scope for
    this mechanical pass.
  • No 26.7.0 / 26.8.0 release notes exist here — latest is
    release-notes/1-71-0-release-notes.md. Flagged as a gap, not fixed: release
    notes are their own deliverable.
  • Historical release notes (1-62-01-71-0) still say "navbar", "Bucket
    tab", "Queries tab". Correctly left alone — they are accurate for their own
    releases.

🤖 Generated with Claude Code

Greptile Summary

Updates the stack-validation smoke test to follow the 26.8.0 catalog sidebar and workspace-global Queries page.

  • Replaces obsolete top-navigation paths with Admin, Volumes, Search, and Queries sidebar entries.
  • Names the current bucket tabs so the success condition is explicit.
  • Directs query validation through the global /queries page.

Confidence Score: 5/5

The PR appears safe to merge with no actionable issue introduced by the changed checklist instructions.

The updated steps consistently replace obsolete controls with the target release’s sidebar routes, while the known stale query expectation predates this navigation-only change and is explicitly deferred.

Important Files Changed

Filename Overview
test-checklists/general-1-stack-validation.md The revised navigation paths and bucket-tab labels consistently update the smoke test for the documented 26.8.0 catalog shell; no changed-code defect was found.

Reviews (1): Last reviewed commit: "Stack-validation checklist: re-home clic..." | Re-trigger Greptile

26.8.0 replaces the top navigation bar with a persistent left sidebar
(Volumes, Search, Queries, Bookmarks, Ask Qurator, Admin), and Queries moved
off the bucket to a global /queries page. Four steps in the smoke test named
controls that no longer exist, so a tester following it would stall.

- Step 1: Admin is a sidebar item, not a user-id dropdown (upper right).
- Step 2: the bucket list is Volumes in the sidebar, not the Q logo; the
  success check now names the current tab set.
- Step 4: Search is a sidebar item, not a top-bar button.
- Step 5: Queries is the global /queries page, not a bucket tab.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant