Skip to content

Acceptance test result must be predictable - #578

Merged
ackleymi merged 2 commits into
quickfixgo:mainfrom
alexppxela:test/acceptance-random-disconnected-peer
Oct 24, 2023
Merged

ackleymi merged 2 commits into
quickfixgo:mainfrom
alexppxela:test/acceptance-random-disconnected-peer

Conversation

@alexppxela

Copy link
Copy Markdown
Contributor

This PR resolves #577

It has been split in 2 commits:

  • 9ce948f
    • This commit only accepts "Connection reset by peer" exception for message errors
      • CompID problem
      • SendingTime accuracy problem
      • Incorrect BeginString
  • 58fc829
    • This commit do not change tests definitions to do not diverge from other quickfix language implementation

I'm open to squash my commits or remove the second commit and update definitions in all fix versions.

Signed-off-by: Alexandre Thibault <alexandre.thibault@artex.io>
Signed-off-by: Alexandre Thibault <alexandre.thibault@artex.io>
@ackleymi
ackleymi merged commit e4cffe0 into quickfixgo:main Oct 24, 2023
@alexppxela
alexppxela deleted the test/acceptance-random-disconnected-peer branch October 25, 2023 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Acceptance tests results are not predictable

2 participants