Skip to content

Check RejectInvalidMessage on FIXT validation #572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ackleymi merged 1 commit into from
Aug 7, 2023
Merged

Check RejectInvalidMessage on FIXT validation #572

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions _test/definitions/server/fix50sp1/14i_RepeatingGroupCountNotEqual.def
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ E8=FIXT.1.19=6735=A34=149=ISLD52=00000000-00:00:00.00056=TW98=0108=2113
#------------------------

#New order message with incorrect repeating group "count". NoTradingSessions (386)
I8=FIXT.1.135=D34=249=TW52=<TIME>56=ISLD11=ID21=140=154=138=200.0055=INTC386=3336=PRE-OPEN336=AFTER-HOURS60=<TIME>
I8=FIXT.1.135=D34=249=TW52=<TIME>56=ISLD11=ID21=140=154=138=200.0055=INTC386=3336=3336=660=<TIME>
# expect a reject
E8=FIXT.1.19=12535=334=249=ISLD52=00000000-00:00:00.00056=TW45=258=Incorrect NumInGroup count for repeating group371=386372=D373=1610=0

Expand All @@ -23,4 +23,4 @@ E8=FIXT.1.19=12535=334=249=ISLD52=00000000-00:00:00.00056=TW45=258=Incor
I8=FIXT.1.135=534=349=TW52=<TIME>56=ISLD
E8=FIXT.1.19=4935=534=349=ISLD52=00000000-00:00:00.00056=TW10=0

eDISCONNECT
eDISCONNECT
4 changes: 2 additions & 2 deletions _test/definitions/server/fix50sp2/14i_RepeatingGroupCountNotEqual.def
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ E8=FIXT.1.19=6735=A34=149=ISLD52=00000000-00:00:00.00056=TW98=0108=2113
#------------------------

#New order message with incorrect repeating group "count". NoTradingSessions (386)
I8=FIXT.1.135=D34=249=TW52=<TIME>56=ISLD11=ID21=140=154=138=200.0055=INTC386=3336=PRE-OPEN336=AFTER-HOURS60=<TIME>
I8=FIXT.1.135=D34=249=TW52=<TIME>56=ISLD11=ID21=140=154=138=200.0055=INTC386=3336=3336=660=<TIME>
# expect a reject
E8=FIXT.1.19=12535=334=249=ISLD52=00000000-00:00:00.00056=TW45=258=Incorrect NumInGroup count for repeating group371=386372=D373=1610=0

Expand All @@ -23,4 +23,4 @@ E8=FIXT.1.19=12535=334=249=ISLD52=00000000-00:00:00.00056=TW45=258=Incor
I8=FIXT.1.135=534=349=TW52=<TIME>56=ISLD
E8=FIXT.1.19=4935=534=349=ISLD52=00000000-00:00:00.00056=TW10=0

eDISCONNECT
eDISCONNECT
12 changes: 7 additions & 5 deletions validation.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,12 +136,14 @@ func validateFIXT(transportDD, appDD *datadictionary.DataDictionary, settings Va
}
}

if err := validateWalk(transportDD, appDD, msgType, msg); err != nil {
return err
}
if settings.RejectInvalidMessage {
if err := validateFields(transportDD, appDD, msgType, msg); err != nil {
return err
}

if err := validateFields(transportDD, appDD, msgType, msg); err != nil {
return err
if err := validateWalk(transportDD, appDD, msgType, msg); err != nil {
return err
}
}

return nil
Expand Down
Loading