Skip to content

@orderby should throw an error if incorrect column syntax is used #288

Description

@metanoid

Using Query.jl in conjunction with DataFrames.jl I find that I often make silly mistakes with the syntax, such as:

df |>
      @orderby(:IssueDate) |>
      DataFrame

instead of

df |>
      @orderby(_.IssueDate) |>
      DataFrame

In such cases, Query.jl simply ignores the @orderby line, and does so silently.

I think that if the arguments to @orderby do not resolve to something in df that can be ordered, there should be a warning thrown, if not an error.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions