Declare internal dependencies under the correct project name - #255
Open
stooit wants to merge 1 commit into
Open
Conversation
Every module here declared its siblings under a project called "quant".
The project on drupal.org is "quantcdn", so the packaging facade generated
a requirement on drupal/quant-quant_api, which does not exist. The
module-level composer packages are therefore uninstallable, and have been
for some time — composer require drupal/quant:2.0.0 fails today:
- drupal/quant 2.0.0 requires drupal/quant-quant_api *
-> could not be found in any version
drupal/quantcdn, the project-level package, resolves cleanly and is what
anyone installing this has actually been using, which is why the broken
alias went unnoticed.
An earlier commit changed quant_api and quant_search from "drupal:" to
"quant:". The first prefix was wrong and so was the second; this uses the
project's real name. The other files carried "quant:" from well before
this work.
Cross-project dependencies were already correct and are untouched:
token:token, purge:purge, webform:webform, tome:tome_static.
Verified by uninstalling and reinstalling all six modules on Drupal 11.4.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The project on drupal.org is
quantcdn, but every module declared its siblings under a project calledquant. The packaging facade turns that into a requirement ondrupal/quant-quant_api, which does not exist, so the module-level composer packages are uninstallable.This is not new — it fails on the current stable release:
drupal/quantcdn(the project-level package) resolves cleanly and requires onlydrupal/core: ^11, which is what people installing this have actually been using — hence nobody hitting the broken alias.PR #254 changed
quant_apiandquant_searchfromdrupal:toquant:. The original prefix was wrong and the replacement was too. This uses the project's real name. The remaining files carriedquant:from long before that work.Cross-project dependencies were already correct and are untouched:
token:token,purge:purge,webform:webform,tome:tome_static.Verified by uninstalling and reinstalling all six modules on Drupal 11.4, and phpcs clean.
Worth confirming the generated metadata on the next dev packaging run — the facade output is the thing this is actually trying to fix.