[ --noinhibit-exec] Fix diagnostic path for output section ALIGN - #1828
Open
Rachit Mehta (rachitmeht) wants to merge 1 commit into
Open
Rachit Mehta (rachitmeht) wants to merge 1 commit into
Rachit Mehta (rachitmeht) wants to merge 1 commit into
Conversation
Shankar Easwaran (quic-seaswara)
approved these changes
Sep 8, 2026
Do not return immediately after reporting a non-power-of-2 ALIGN value for an output section when diagnostics allow linking to continue. This lets later diagnostics, such as assignOffsets() warnings, still be reported under --noinhibit-exec. Add coverage for the normal fatal path and the --noinhibit-exec path that continues far enough to report non-allocatable section placement warnings. Fixes qualcomm#1826 Signed-off-by: Rachit Mehta <rachmeht@qti.qualcomm.com>
Shankar Easwaran (quic-seaswara)
force-pushed
the
fix/noinhibit-create-output-section-1826
branch
from
September 14, 2026 22:21
eb57514 to
e5e8f78
Compare
Steven Ramirez Rosa (Steven6798)
approved these changes
Sep 16, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not return immediately after reporting a non-power-of-2 ALIGN value for an output section when diagnostics allow linking to continue. This lets later diagnostics, such as assignOffsets() warnings, still be reported under --noinhibit-exec.
Add coverage for the normal fatal path and the --noinhibit-exec path that continues far enough to report non-allocatable section placement warnings.
Resolves #1826