Skip to content

platforms/iq-x7181-evk: remove the ADSP filenames - #153

Open
Vivek Magre (vmagre) wants to merge 1 commit into
qualcomm-linux:mainfrom
vmagre:feature/remove_Dspnames
Open

platforms/iq-x7181-evk: remove the ADSP filenames#153
Vivek Magre (vmagre) wants to merge 1 commit into
qualcomm-linux:mainfrom
vmagre:feature/remove_Dspnames

Conversation

@vmagre

@vmagre Vivek Magre (vmagre) commented Aug 5, 2026

Copy link
Copy Markdown

Removing the adsp_lite.lzma and adsp_dtbs.elf file name.
The ADSP files are not boot critical binary those are included in HLOS.

@vmagre
Vivek Magre (vmagre) force-pushed the feature/remove_Dspnames branch 2 times, most recently from baae017 to fdd77b2 Compare August 5, 2026 06:14
lumag
Dmitry Baryshkov (lumag) requested changes Aug 5, 2026
View reviewed changes

@lumag Dmitry Baryshkov (lumag) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First the definition of the issue, then actions to be performed.

@vmagre
Vivek Magre (vmagre) force-pushed the feature/remove_Dspnames branch 2 times, most recently from 2ba1b59 to e4b82a0 Compare August 12, 2026 13:56
@vmagre

Vivek Magre (vmagre) commented Aug 12, 2026 •
edited
Loading

Copy link
Copy Markdown
Author

Hi Dmitry Baryshkov (@lumag)
Currently the ADSP files are available via the tech package (link) as part of boot critical binaries and the upstream firmware (link)
but the ADSP upstream firmware files are included in the HLOS(rootfs),
the upstream files get mounted in the "/lib/firmware/qcom/x1e80100/" path in HLOS(rootfs)
the files from the boot critical binaries are not utilizes by the HLOS and are redundant.
Also, these ADSP files are boot critical related binaries and are not required in the boot critical binary zip.

lumag
Dmitry Baryshkov (lumag) requested changes Aug 15, 2026
View reviewed changes

@lumag Dmitry Baryshkov (lumag) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still. What it the issue that you are trying to fix?

@vmagre

Vivek Magre (vmagre) commented Aug 20, 2026

Copy link
Copy Markdown
Author

Hi Dmitry Baryshkov (@lumag)
from the upcoming tech package releases, we will not be including the adsp file(adsp_lite.lzma and adsp_dtbs.elf) in tech package,
to avoid the failure on meta-qcom for upcoming release (due to file missing the build will fail on the meta-qcom) we want to keep the partition updated.

@lumag

Dmitry Baryshkov (lumag) commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Vivek Magre (@vmagre) please add that information to the commit message. Make sure that it follow the logic: start with the description of the issue before describing the fixing mesaures.

@vmagre
Vivek Magre (vmagre) force-pushed the feature/remove_Dspnames branch 2 times, most recently from a89c682 to a9aa780 Compare August 21, 2026 07:30
@vmagre

Vivek Magre (vmagre) commented Aug 21, 2026

Copy link
Copy Markdown
Author

Hi Dmitry Baryshkov (@lumag)
i have updated the commit with the details,
please review it once and approve the PR

lumag
Dmitry Baryshkov (lumag) requested changes Aug 23, 2026
View reviewed changes

@lumag Dmitry Baryshkov (lumag) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure about the ADSP firmware being not necessary before HLOS? Isn't it being loaded by the bootloaders to handle USB-C and charging before Linux boots?

Also, there is no need to update something before it happens. The PR updating to the next boot firmware revision can include this commit.

Last, but not least.

Updating the partition file to prevent build failures in meta-qcom caused by missing files in future releases.

This line is too long and also doesn't follow commit guidelines.

@vmagre

Vivek Magre (vmagre) commented Aug 25, 2026

Copy link
Copy Markdown
Author

Hi Dmitry Baryshkov (@lumag) , i have confirmed offline with the platform team, the ADSP early boot is not enabled for the IQX7181/IQX5121,
ADSP will load in the OS bootup not during the uefi or bootloader

the ADSP early boot is enabled for the QCS615, QCS8300, QCS9100, QCS6490 targets.

@vmagre

Vivek Magre (vmagre) commented Aug 25, 2026

Copy link
Copy Markdown
Author

Updated the commit message to resolve line length,

lumag
Dmitry Baryshkov (lumag) requested changes Aug 25, 2026
View reviewed changes

@lumag Dmitry Baryshkov (lumag) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

upstream firmware package and is included in the
HLOS (rootfs), mounted at:

/lib/firmware/qcom/x1e80100/

No, it's not mounted there.

The copies in the boot critical binary zip are not
utilized by HLOS and are therefore redundant.
Additionally, ADSP files are not required as boot
critical binaries.

And what does that have to do with the firmware being flashed to the corresponding partitions?

Finally, if we do no longer want to flash those, why don't we also remove the partitions?

Finally, now your commit message have too short lines. What is the standard recommended length? Which line length did you set in your editor?

@vmagre

Vivek Magre (vmagre) commented Sep 7, 2026

Copy link
Copy Markdown
Author

Hi Dmitry Baryshkov (@lumag)
we had a discussion with the ADSP team,

  1. The partitions “ADSP_UEFI”, "ADSP_UEFI_DTB", "ADSP_UEFI_DTB_BACKUP", "ADSP_UEFI_BACKUP"
    was required in the base Windows program which got carried to the Linux and the Ubuntu programs at start of the project,
    Currently we can't remove the partitions as it will break OTA.

  2. adsp_lite.lzma
    this file is required for the charger functionality in the Windows program, and it is not required for the Linux and the Ubuntu programs.

  3. adsp_dtbs.elf ( adsp_dtb.mbn )
    The above file is with name of the “adsp_dtbs.elf” in the ADSP internal build and it will be renamed to the “adsp_dtb.mbn” while upstreaming to the Linux-firmware.
    then from the upstream the ADSP and CDSP files (cdsp.mbn, cdsp_dtb.mbn, adsp.mbn, adsp_dtb.mbn) will be copied to the path “/lib/firmware/qcom/x1e80100/” in the rootfs which are required for the ADSP and CDSP bootup.

@vmagre
platforms/iq-x7181-evk: Removal of the ADSP filenames
6e45f2a 
The ADSP files (adsp_lite.lzma and adsp_dtbs.elf) are currently
included in the tech package as part of boot critical binaries.

adsp_lite.lzma is required only for charger functionality in the
Windows program and is not required for Linux and Ubuntu programs.

adsp_dtbs.elf is the ADSP internal build name for the DTB binary,
which is renamed to adsp_dtb.mbn during upstreaming to
linux-firmware. The upstream firmware files (adsp.mbn,
adsp_dtb.mbn, cdsp.mbn, cdsp_dtb.mbn) are provided via the
upstream firmware package and are included in the HLOS (rootfs),
mounted at: /lib/firmware/qcom/x1e80100/

The copies in the boot critical binary zip are not utilized by
HLOS and are therefore redundant. Additionally, ADSP files are
not required as boot critical binaries.

Note: The partitions "ADSP_UEFI", "ADSP_UEFI_DTB",
"ADSP_UEFI_DTB_BACKUP" and "ADSP_UEFI_BACKUP" are retained as
they cannot be removed without breaking OTA, even though they
were originally carried over from the Windows program to Linux
and Ubuntu programs at the start of the project.

Signed-off-by: Vivek Magre <vmagre@qti.qualcomm.com>
@vmagre

Vivek Magre (vmagre) commented Sep 7, 2026 •
edited
Loading

Copy link
Copy Markdown
Author

Updated the commit message with the details of the discussion with ADSP team.
please review it once and approve the PR

@lumag

Dmitry Baryshkov (lumag) commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Hi Dmitry Baryshkov (Dmitry Baryshkov (@lumag)) we had a discussion with the ADSP team,

  1. The partitions “ADSP_UEFI”, "ADSP_UEFI_DTB", "ADSP_UEFI_DTB_BACKUP", "ADSP_UEFI_BACKUP"
    was required in the base Windows program which got carried to the Linux and the Ubuntu programs at start of the project,
    Currently we can't remove the partitions as it will break OTA.

I don't think so. Does OTA work on per-partition or per-block boundaries?

  1. adsp_lite.lzma
    this file is required for the charger functionality in the Windows program, and it is not required for the Linux and the Ubuntu programs.

Why? What's the difference? Don't we handover from the UEFI to the HLOS?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vkraleti Viswanath Kraleti (vkraleti) Awaiting requested review from vkraleti vkraleti is a code owner
@ndechesne Nicolas Dechesne (ndechesne) Awaiting requested review from ndechesne ndechesne is a code owner
@lumag Dmitry Baryshkov (lumag) Awaiting requested review from lumag lumag is a code owner

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vmagre @lumag