FROMLIST: PCI: qcom: Add D3cold support - #1038
Open
ziyuezhang-123 wants to merge 1 commit into
Open
Conversation
During resume from D3cold, set the PCIe controller to the maximum OPP before enabling the ICC paths and accessing DBI registers. Without this, qcom_pcie_icc_opp_update() may access DBI before OPP votes are restored, triggering NoC errors. The qli2.0 branch merged the D3cold patch (PR qualcomm-linux#461) before the 'Set max OPP before DBI access during resume' fix was applied, so the if (pcie->use_pm_opp) block was missing from the if (pcie->pci->suspended) branch in qcom_pcie_resume_noirq(). This commit brings qli2.0 in sync with upstream commit 2cc0e74. CRs-Fixed: 4569097 Link: https://lore.kernel.org/all/20260429-d3cold-v5-5-89e9735b9df6@oss.qualcomm.com/ Signed-off-by: Krishna Chaitanya Chundru <krishna.chundru@oss.qualcomm.com> Signed-off-by: Ziyue Zhang <ziyue.zhang@oss.qualcomm.com>
ziyuezhang-123
requested review from
a team,
Kaushal Kumar (quic-kaushalk),
Ricardo Salveti (ricardosalveti) and
Salendarsingh Gaud (sgaud-quic)
September 3, 2026 10:24
|
Merge Check Failed: No Change Task Found No associated change tasks found for CR 4569097 on any of the following entities: Entities:
CR: 4569097 Please ensure the CR has a change task associated with at least one of the entities for this branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During resume from D3cold, set the PCIe controller to the maximum OPP
before enabling the ICC paths and accessing DBI registers. Without this,
qcom_pcie_icc_opp_update() may access DBI before OPP votes are restored,
triggering NoC errors.
The qli2.0 branch merged the D3cold patch (PR #461) before the
'Set max OPP before DBI access during resume' fix was applied, so the
if (pcie->use_pm_opp) block was missing from the if (pcie->pci->suspended)
branch in qcom_pcie_resume_noirq(). This commit brings qli2.0 in sync
with upstream commit 2cc0e74.
Signed-off-by: Krishna Chaitanya Chundru krishna.chundru@oss.qualcomm.com
Signed-off-by: Ziyue Zhang ziyue.zhang@oss.qualcomm.com
CRs-Fixed: 4569097
Link: https://lore.kernel.org/all/20260429-d3cold-v5-5-89e9735b9df6@oss.qualcomm.com/