[pytorchbot]

Summary:

Check that out.nbytes() is at least as large as src.nbytes() to prevent copying beyond the range of src.

Also add a check on dtypes, make sure out and src dtypes are the same. Otherwise we may copy the wrong dtype without conversion.

The crash is a write-heap-buffer-overflow that occurs in the torch::executor::native::copy_out function. The root cause is that the std::memcpy operation in this function does not check if the destination buffer out is large enough to hold the data from the source tensor src. Specifically, the condition internal::sizes_match_ignoring_leading_1s(out.sizes(), src.sizes()) checks if the sizes of out and src match, ignoring any leading dimensions of size 1 in out, but it does not guarantee that out.nbytes() is greater than or equal to src.nbytes().

The patch fixes the crash by adding an additional check out.nbytes() >= src.nbytes() before performing the std::memcpy operation. This ensures that the destination buffer out is large enough to hold the data from src, preventing the buffer overflow.

if (internal::sizes_match_ignoring_leading_1s(out.sizes(), src.sizes()) &&
    src.numel() > 0 && out.nbytes() >= src.nbytes()) {
  std::memcpy(out.mutable_data_ptr(), src.const_data_ptr(), src.nbytes());
}

Other considerations that reviewers should take into account when validating the patch include verifying that the additional check does not introduce any performance regressions and that it correctly handles edge cases, such as when src is empty or when out and src have different data types. Reviewers should also check that the patch does not affect the functionality of the copy_out function in other scenarios. Additionally, it is worth verifying that the fix is consistent with the existing error handling and checking mechanisms in the copy_out function.

NOTE: This diff is entirely auto-generated by LLM-based patch generator.
Reviewer should carefully examine this diff as Lionhead does not guarrantee the
correctnesss of the patch beyond fixing the crash and passing existing tests.
Please commandeer this diff and revise as needed. Our bot does not respond to
comments or revision requests (yet).

Differential Revision: D80885980

[pytorch-bot]

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15784

• 📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 2 Cancelled Jobs

As of commit 5dcf5c6 with merge base e0dda90 ():

NEW FAILURES - The following jobs have failed:

• pull / unittest / linux / linux-job (gh)
  backends/xnnpack/test/recipes/test_xnnpack_recipes.py::TestXnnpackRecipes::test_int8_static_quant_recipe
• pull / unittest-editable / linux / linux-job (gh)
  backends/xnnpack/test/recipes/test_xnnpack_recipes.py::TestXnnpackRecipes::test_int8_static_quant_recipe

CANCELLED JOBS - The following jobs were cancelled. Please retry:

• pull / unittest / macos / macos-job (gh)
  ##[error]The operation was canceled.
• pull / unittest-editable / macos / macos-job (gh)
  ##[error]The operation was canceled.

This comment was automatically generated by Dr. CI and updates every 15 minutes.