Skip to content

Do not copy beyond out tensor bounds - #15648

Merged
meta-codesync[bot] merged 1 commit into
pytorch:mainfrom
lucylq:export-D86436435
Nov 7, 2025
Merged

meta-codesync[bot] merged 1 commit into
pytorch:mainfrom
lucylq:export-D86436435

Conversation

@lucylq

@lucylq lucylq commented Nov 6, 2025

Copy link
Copy Markdown
Contributor

Summary:
set_all_to_value(out_data, out_step_len, value) loops over the padding and copies a row at a time.

Add some checks to make sure we do not exceed the out tensor (out_data) size when copying.

Differential Revision: D86436435

@pytorch-bot

pytorch-bot Bot commented Nov 6, 2025 •

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15648

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (2 Unrelated Failures)

As of commit 76104b3 with merge base 3dbc15b (image):

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 6, 2025
@meta-codesync

meta-codesync Bot commented Nov 6, 2025

Copy link
Copy Markdown
Contributor

@lucylq has exported this pull request. If you are a Meta employee, you can view the originating Diff in D86436435.

@github-actions

github-actions Bot commented Nov 6, 2025

Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

lucylq added a commit to lucylq/executorch-1 that referenced this pull request Nov 6, 2025
Summary:

`set_all_to_value(out_data, out_step_len, value)` loops over the padding and copies a row at a time.

Add some checks to make sure we do not exceed the out tensor (out_data) size when copying.

Differential Revision: D86436435
@lucylq
lucylq force-pushed the export-D86436435 branch 2 times, most recently from 18cf8e6 to b6ba8eb Compare November 6, 2025 19:21
lucylq added a commit to lucylq/executorch-1 that referenced this pull request Nov 6, 2025
Summary:

`set_all_to_value(out_data, out_step_len, value)` loops over the padding and copies a row at a time.

Add some checks to make sure we do not exceed the out tensor (out_data) size when copying.

Differential Revision: D86436435
lucylq added a commit to lucylq/executorch-1 that referenced this pull request Nov 7, 2025
Summary:

`set_all_to_value(out_data, out_step_len, value)` loops over the padding and copies a row at a time.

Add some checks to make sure we do not exceed the out tensor (out_data) size when copying.

Differential Revision: D86436435
lucylq added a commit to lucylq/executorch-1 that referenced this pull request Nov 7, 2025
Summary:

`set_all_to_value(out_data, out_step_len, value)` loops over the padding and copies a row at a time.

Add some checks to make sure we do not exceed the out tensor (out_data) size when copying.

Reviewed By: JacobSzwejbka

Differential Revision: D86436435
Summary:

`set_all_to_value(out_data, out_step_len, value)` loops over the padding and copies a row at a time.

Add some checks to make sure we do not exceed the out tensor (out_data) size when copying.

Reviewed By: JacobSzwejbka

Differential Revision: D86436435
@meta-codesync
meta-codesync Bot merged commit f41d81a into pytorch:main Nov 7, 2025
142 of 145 checks passed
@lucylq

lucylq commented Nov 10, 2025

Copy link
Copy Markdown
Contributor Author

@pytorchbot cherry-pick --onto release/1.0 -c critical

pytorchbot pushed a commit that referenced this pull request Nov 10, 2025
Differential Revision: D86436435

Pull Request resolved: #15648

(cherry picked from commit f41d81a)
@pytorchbot

Copy link
Copy Markdown
Collaborator

Cherry picking #15648

The cherry pick PR is at #15717 and it is recommended to link a critical cherry pick PR with an issue. The following tracker issues are updated:

Details for Dev Infra team Raised by workflow job

GregoryComer pushed a commit that referenced this pull request Nov 15, 2025
Differential Revision: D86436435

Pull Request resolved: #15648

(cherry picked from commit f41d81a)
jirioc pushed a commit to nxp-upstream/executorch that referenced this pull request Dec 19, 2025
Differential Revision: D86436435

Pull Request resolved: pytorch#15648
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants