Repository navigation
Remove WeightTensorWithLinearActivationScaleMetadata and related code - #4262
Merged
Merged
Conversation
Summary: Delete `linear_activation_weight_observed_tensor.py` and the `insert_observers_` function that depended on it. Also remove the `TestLinearObserver` test class and unused imports. Test Plan: pytest test/quantization/test_observer.py -x [ghstack-poisoned]
Summary: Delete `linear_activation_scale.py` which defined `WeightTensorWithLinearActivationScaleMetadata` and its helper `to_weight_tensor_with_linear_activation_scale_metadata`. Remove the import and `__all__` entry from `torchao/quantization/__init__.py`. Test Plan: python -c "import torchao.quantization" [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/4262
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
Bot
added
the
CLA Signed
This was referenced Apr 10, 2026
jerryzh168
added
the
module: not user facing
andrewor14
approved these changes
Apr 10, 2026
Contributor
|
@claude review |
|
Claude finished @andrewor14's task in 44s —— View job Review of PR #4262
LGTM. Clean deletion with no loose ends. What's removed:
Verified: No remaining references to No issues found. |
…leMetadata and related code" Summary: Delete `linear_activation_scale.py` which defined `WeightTensorWithLinearActivationScaleMetadata` and its helper `to_weight_tensor_with_linear_activation_scale_metadata`. Remove the import and `__all__` entry from `torchao/quantization/__init__.py`. Test Plan: python -c "import torchao.quantization" [ghstack-poisoned]
…elated code" Summary: Delete `linear_activation_scale.py` which defined `WeightTensorWithLinearActivationScaleMetadata` and its helper `to_weight_tensor_with_linear_activation_scale_metadata`. Remove the import and `__all__` entry from `torchao/quantization/__init__.py`. Test Plan: python -c "import torchao.quantization" [ghstack-poisoned]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Summary:
Delete
linear_activation_scale.pywhich definedWeightTensorWithLinearActivationScaleMetadataand its helperto_weight_tensor_with_linear_activation_scale_metadata. Remove theimport and
__all__entry fromtorchao/quantization/__init__.py.Test Plan:
python -c "import torchao.quantization"