Repository navigation
remove per kernel fp8 triton quantized benchmarks - #4166
Merged
Merged
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/4166
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 9717b75 with merge base bca91b0 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
| m_values=args.m_values, | ||
| k=args.k, | ||
| block_size=args.block_size, | ||
| bandwidth_spec=bandwidth_spec, |
Contributor
There was a problem hiding this comment.
can we also update this script to only measure against peak achievable bandwidth as defined in the gpu_spec in roofline_utils.py we import (not measure against the "advertised max theoretical bandwidth" number)
Contributor
Author
Contributor
There was a problem hiding this comment.
let's just keep vs_achievable
Contributor
Author
There was a problem hiding this comment.
done, added print to make it clear to user as well what achievable % is used
danielvegamyhre
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
This removes the redundant bench_triton_fp8_* quant benchmark scripts under benchmarks/prototype/blockwise_fp8_training and consolidates their correctness coverage into benchmark_quant_kernel_bandwidth.py.
The consolidated benchmark now has an optional --check-correctness mode that compares each Triton quant kernel against the corresponding Torch reference implementation, including layout/stride checks where applicable. The weight-kernel references were adjusted to match Triton’s column-major outputs and scales, which was required for weight_quant_rhs and weight_quant_transposed_rhs.
Testing