[stdlib] Allow loop.create_task eager_start on Python 3.13 - #16142
Open
nightcityblade wants to merge 1 commit into
Open
[stdlib] Allow loop.create_task eager_start on Python 3.13#16142nightcityblade wants to merge 1 commit into
nightcityblade wants to merge 1 commit into
Conversation
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15269.
Python 3.13.3 added arbitrary keyword forwarding to event-loop
create_task, which allowseager_startto be passed to a compatible task factory. Move the existing loop-specificeager_startsignature gate from Python 3.14 to Python 3.13 while leaving the high-levelasyncio.create_taskandTaskGroup.create_taskgates unchanged.Add regression coverage for both
AbstractEventLoopandBaseEventLoop.Tests:
pre-commit run --files stdlib/asyncio/base_events.pyi stdlib/asyncio/events.pyi stdlib/@tests/test_cases/asyncio/check_task.pypython tests/mypy_test.py stdlib/asyncio -p 3.13python tests/pyright_test.py stdlib/asyncio --pythonversion 3.13 -p pyrightconfig.stricter.jsonpython tests/pyright_test.py stdlib/@tests/test_cases/asyncio/check_task.py --pythonversion 3.13 -p pyrightconfig.testcases.jsonpython tests/regr_test.py stdlib -p 3.13